Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 0ad7cb925edff3f14bd47fdb7ef3c0b6186960d4
https://github.com/qemu/qemu/commit/0ad7cb925edff3f14bd47fdb7ef3c0b6186960d4
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M hw/9pfs/9p.c
M hw/9pfs/trace-events
Log Message:
-----------
9pfs: improve v9fs_walk() tracing
'Twalk' is the most important request type in the 9p protocol to look out
for when debugging 9p communication. That's because it is the only part
of the 9p protocol which actually deals with human-readable path names,
whereas all other 9p request types work on numeric file IDs (FIDs) only.
Improve tracing of 'Twalk' requests, e.g. let's say client wanted to walk
to "/home/bob/src", then improve trace output from:
v9fs_walk tag 0 id 110 fid 0 newfid 1 nwnames 3
to:
v9fs_walk tag=0 id=110 fid=0 newfid=1 nwnames=3 wnames={home, bob, src}
To achieve this, add a new helper function trace_v9fs_walk_wnames() which
converts the received V9fsString array of individual path elements into a
comma-separated string presentation for being passed to the tracing system.
As this conversion is somewhat expensive, this conversion function is only
called if tracing of event 'v9fs_walk' is currently enabled.
Signed-off-by: Christian Schoenebeck <[email protected]>
Reviewed-by: Greg Kurz <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Message-Id: <[email protected]>
Commit: a2f17bd40b3d302f6c1ddf0da75d2343966e0a3f
https://github.com/qemu/qemu/commit/a2f17bd40b3d302f6c1ddf0da75d2343966e0a3f
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M hw/9pfs/9p-local.c
M qemu-options.hx
Log Message:
-----------
9pfs: make multidevs=remap default
1a6ed33cc5 introduced option multidevs=remap|forbid|warn and made
"warn" the default option.
As it turned out though, e.g. by several reports in conjunction with
following 9p client issue:
https://github.com/torvalds/linux/commit/850925a8133c73c4a2453c360b2c3beb3bab67c9
Many people are just ignoring this warning, or even do not notice the
warning at all. Therefore make multidevs=remap the new default option to
prevent people to run into such kind of severe misbehaviours in the first
place.
>From performance PoV the runtime overhead of multidevs=remap is
neglectable with few or even just only one device being shared with the
same 9p export, expected to be constant Theta(1). The inode numbers
emitted to guest also just loose one bit (since 6b6aa8285d) for the 1st
device being shared.
Signed-off-by: Christian Schoenebeck <[email protected]>
Message-Id:
<09cc84e5561f66b6a8cf49b3532c6c78a6acc806.1734876877.git.qemu_...@crudebyte.com>
Commit: 9a0dd4b3e4e0b06ec35c5ac370f54a36ea1846ed
https://github.com/qemu/qemu/commit/9a0dd4b3e4e0b06ec35c5ac370f54a36ea1846ed
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
A hw/9pfs/9p-util-generic.c
M hw/9pfs/9p-util.h
M hw/9pfs/9p.c
M hw/9pfs/meson.build
M hw/9pfs/trace-events
Log Message:
-----------
9pfs: improve v9fs_open() tracing
Improve tracing of 9p 'Topen' request type by showing open() flags as
human-readable text.
E.g. trace output:
v9fs_open tag 0 id 12 fid 2 mode 100352
would become:
v9fs_open tag=0 id=12 fid=2 mode=100352(RDONLY|NONBLOCK|DIRECTORY|
TMPFILE|NDELAY)
Therefor add a new utility function qemu_open_flags_tostr() that converts
numeric open() flags from host's native O_* flag constants to a string
presentation.
9p2000.L and 9p2000.u protocol variants use different numeric 'mode'
constants for 'Topen' requests. Instead of writing string conversion code
for both protocol variants, use the already existing conversion functions
that convert the mode flags from respective protocol constants to host's
native open() numeric flag constants and pass that result to the new
string conversion function qemu_open_flags_tostr().
Signed-off-by: Christian Schoenebeck <[email protected]>
Message-Id: <[email protected]>
Commit: 3d68de855175ae590479f15b37e8db300d43e860
https://github.com/qemu/qemu/commit/3d68de855175ae590479f15b37e8db300d43e860
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M tests/qtest/virtio-9p-test.c
Log Message:
-----------
tests/9p: rename test use_after_unlink -> use_file_after_unlink
To pave the way for adding new test use_dir_after_unlink with subsequent
patch, i.e. making it clear that the existing test is just about unlinked
files, not unlinked directories.
Signed-off-by: Christian Schoenebeck <[email protected]>
Message-Id:
<9d2ca46a58b812ad17ca7bb8a84f12252d3e3832.1736427878.git.qemu_...@crudebyte.com>
Commit: 37c21fb972da373be101d20574309be0584dc2a3
https://github.com/qemu/qemu/commit/37c21fb972da373be101d20574309be0584dc2a3
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M tests/qtest/virtio-9p-test.c
Log Message:
-----------
tests/9p: add use_dir_after_unlink test
After removing a directory from the filesystem, it should still be
possible to operate on the directory if the directory has been opened
before.
As a first step this new test will verify whether Tgetattr request
works on the unlinked directory.
Signed-off-by: Christian Schoenebeck <[email protected]>
Message-Id:
<0a9b3419356731e34b1be4a8577d6b416379d085.1736427878.git.qemu_...@crudebyte.com>
Commit: 6eadd8767ab9422942c3c5e8d70c923e5ee3aa3f
https://github.com/qemu/qemu/commit/6eadd8767ab9422942c3c5e8d70c923e5ee3aa3f
Author: Christian Schoenebeck <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M tests/qtest/virtio-9p-test.c
Log Message:
-----------
tests/9p: extend use_dir_after_unlink test with Treaddir
Sending a Treaddir request on an unlinked directory should also succeed
if the directory was alread opened before unlink. We just check that no
error occurs and that we get some kind of Treaddir result, but completely
ignore the actual Treaddir result content. In fact, there should be no
system as of to date that would allow a removed directory to have any
content (files, links, devices, subdirectories) and POSIX specifies that
a directory must be empty when trying to remove it from the file system.
Signed-off-by: Christian Schoenebeck <[email protected]>
Message-Id:
<f1b91e3a33a6502be816d88dfb6b719101b69d41.1736427878.git.qemu_...@crudebyte.com>
Commit: bfa7bf02782dbd996201c90f850ca11730041af1
https://github.com/qemu/qemu/commit/bfa7bf02782dbd996201c90f850ca11730041af1
Author: Greg Kurz <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: Mark me as reviewer only for 9pfs
I still review 9pfs changes from time to time but I'm definitely
not able to do actual maintainer work. Drop my tree on the way
as I'll obviously not use it anymore, and it has been left
untouched since May 2020.
Signed-off-by: Greg Kurz <[email protected]>
Reviewed-by: Christian Schoenebeck <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Christian Schoenebeck <[email protected]>
Commit: baec9cfadf4271017331717cb07207b2cc6f7494
https://github.com/qemu/qemu/commit/baec9cfadf4271017331717cb07207b2cc6f7494
Author: Paolo Bonzini <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M meson.build
Log Message:
-----------
rust: add --rust-target option for bindgen
Without it, recent bindgen will give an error
error: extern block cannot be declared unsafe
if rustc is not new enough to support the "unsafe extern" construct.
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Commit: a2674f523670672e7de44e6fa4d0aa1032b3b9dc
https://github.com/qemu/qemu/commit/a2674f523670672e7de44e6fa4d0aa1032b3b9dc
Author: Stefan Hajnoczi <[email protected]>
Date: 2025-02-06 (Thu, 06 Feb 2025)
Changed paths:
M MAINTAINERS
M hw/9pfs/9p-local.c
A hw/9pfs/9p-util-generic.c
M hw/9pfs/9p-util.h
M hw/9pfs/9p.c
M hw/9pfs/meson.build
M hw/9pfs/trace-events
M qemu-options.hx
M tests/qtest/virtio-9p-test.c
Log Message:
-----------
Merge tag 'pull-9p-20250206' of https://github.com/cschoenebeck/qemu into
staging
* Greg Kurz steps back as maintainer of 9pfs.
* Make multidevs=remap default option (instead of multidevs=warn)
and update documentation related to this option.
* Improve tracing (i.e. usefulness of log output content).
* Add test cases for accessing a directory after removal.
# -----BEGIN PGP SIGNATURE-----
#
# iQJLBAABCgA1FiEEltjREM96+AhPiFkBNMK1h2Wkc5UFAmek5kYXHHFlbXVfb3Nz
# QGNydWRlYnl0ZS5jb20ACgkQNMK1h2Wkc5URKA//YY/32Poo8pQ6dN6qTdU465ku
# mIH+TE6j0EVFkIY/gO//UJe8LEztqx+kvRwWuvJ5YEiHCIY7sUZ53yivh7YLqKRz
# uWB/VYRXI1AKi7hF0sLghTJnu08G/IWz56sCKYiRvW6kNld6y9LC4FQpj/KrShok
# M41lqTAv+umwD9NHoN8jdtT0cZZIWSLJft1rjzpItZQX+nDuIUkqFS1kT8AW/wr0
# yvwpK0cMYx6qP2E0WIISs4B0jE1UdR4jAxsEkFLKJLRfSSHg6no5GsMZWWXaFG4G
# 37ok7aaMETw8Up4kTaG2t2TYD2s5HF33d5iOv+9+4ADwDtM09abFrQ6u2DzuAr9F
# gjxh3RPkUZJbO2dIm0dPEjYOgbhAyhQtHh1vOIKFdEEJZVnpfvVPHMzTnT1YZ/R0
# 4GeAG3+k88ZrZm8l5CjCTsPNVqTqNEIdmNiL7VwVKWYnSA5xSBv7bHRn+rcLEAMK
# n+h1HFqv1TbPp+4Vr8mkNOxTkfLnUHyCDHNBWwk7/soPqi7SEWtdLvL/5fI1SWCO
# 0FZEylVNPB/nby5dhGWIy2ROq7HnIZkj77LB9zSESq/OIvyEyOEOMZDcKmLvdRJy
# kTIp1hkooO5Ji2F7eASHt+AOGs3XdA0N5yrStLUjoG07yum6wdPT7Puk6rUpX6gV
# pRW0V+BCxI6hHCkH3hA=
# =0HI6
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 06 Feb 2025 11:41:42 EST
# gpg: using RSA key 96D8D110CF7AF8084F88590134C2B58765A47395
# gpg: issuer "[email protected]"
# gpg: Good signature from "Christian Schoenebeck <[email protected]>"
[unknown]
# gpg: WARNING: The key's User ID is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: ECAB 1A45 4014 1413 BA38 4926 30DB 47C3 A012 D5F4
# Subkey fingerprint: 96D8 D110 CF7A F808 4F88 5901 34C2 B587 65A4 7395
* tag 'pull-9p-20250206' of https://github.com/cschoenebeck/qemu:
MAINTAINERS: Mark me as reviewer only for 9pfs
tests/9p: extend use_dir_after_unlink test with Treaddir
tests/9p: add use_dir_after_unlink test
tests/9p: rename test use_after_unlink -> use_file_after_unlink
9pfs: improve v9fs_open() tracing
9pfs: make multidevs=remap default
9pfs: improve v9fs_walk() tracing
Signed-off-by: Stefan Hajnoczi <[email protected]>
Compare: https://github.com/qemu/qemu/compare/d922088eb4ba...a2674f523670
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
