Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3f9f6299a1bc46ff462142c7398a5953e3640cc2
https://github.com/qemu/qemu/commit/3f9f6299a1bc46ff462142c7398a5953e3640cc2
Author: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/tap.c
Log Message:
-----------
net/tap: drop too small packets
Theoretically tap_read_packet() may return size less than
s->host_vnet_hdr_len, and next, we'll work with negative size
(in case of !s->using_vnet_hdr). Let's avoid it.
Don't proceed with size == s->host_vnet_hdr_len as well in case
of !s->using_vnet_hdr, it doesn't make sense.
Tested-by: Lei Yang <leiy...@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: ea263e8fd9a8f9cff615631a9bda775f5ddd3f98
https://github.com/qemu/qemu/commit/ea263e8fd9a8f9cff615631a9bda775f5ddd3f98
Author: Steve Sistare <steven.sist...@oracle.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/tap.c
Log Message:
-----------
tap: fix net_init_tap() return code
net_init_tap intends to return 0 for success and -1 on error. However,
when net_init_tap() succeeds for a multi-queue device, it returns 1,
because of this code where ret becomes 1 when g_unix_set_fd_nonblocking
succeeds:
ret = g_unix_set_fd_nonblocking(fd, true, NULL);
if (!ret) {
... error ...
free_fail:
...
return ret;
Luckily, the only current call site checks for negative, rather than non-zero:
net_client_init1()
if (net_client_init_fun[](...) < 0)
Also, in the unlikely case that g_unix_set_fd_nonblocking fails and returns
false, ret=0 is returned, and net_client_init1 will use a broken interface.
Fix it to be future proof.
Signed-off-by: Steve Sistare <steven.sist...@oracle.com>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 871a6e5b339f0b5e71925ec7d3f452944a1c82d3
https://github.com/qemu/qemu/commit/871a6e5b339f0b5e71925ec7d3f452944a1c82d3
Author: Peter Maydell <peter.mayd...@linaro.org>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M hw/net/npcm_gmac.c
Log Message:
-----------
hw/net/npcm_gmac.c: Send the right data for second packet in a row
The transmit loop in gmac_try_send_next_packet() is constructed in a
way that means it will send incorrect data if it it sends more than
one packet.
The function assembles the outbound data in a dynamically allocated
block of memory which is pointed to by tx_send_buffer. We track the
first point in this block of memory which is not yet used with the
prev_buf_size offset, initially zero. We track the size of the
packet we're sending with the length variable, also initially zero.
As we read chunks of data out of guest memory, we write them to
tx_send_buffer[prev_buf_size], and then increment both prev_buf_size
and length. (We might dynamically reallocate the buffer if needed.)
When we send a packet, we checksum and send length bytes, starting at
tx_send_buffer, and then we reset length to 0. This gives the right
data for the first packet. But we don't reset prev_buf_size. This
means that if we process more descriptors with further data for the
next packet, that data will continue to accumulate at offset
prev_buf_size, i.e. after the data for the first packet. But when
we transmit that second packet, we send length bytes from
tx_send_buffer, so we will send a packet which has the length of the
second packet but the data of the first one.
The fix for this is to also clear prev_buf_size after the packet has
been sent -- we never need the data from packet one after we've sent
it, so we can write packet two's data starting at the beginning of
the buffer.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 01b327c9a609cb613da1e04c5af5f4fcc7d9c0a3
https://github.com/qemu/qemu/commit/01b327c9a609cb613da1e04c5af5f4fcc7d9c0a3
Author: Peter Maydell <peter.mayd...@linaro.org>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M hw/net/npcm_gmac.c
Log Message:
-----------
hw/net/npcm_gmac.c: Unify length and prev_buf_size variables
After the bug fix in the previous commit, the length and prev_buf_size
variables are identical, except that prev_buf_size is uint32_t and
length is uint16_t. We can therefore unify them. The only place where
the type makes a difference is that we will truncate the packet
at 64K when sending it; this commit preserves that behaviour
by using a local variable when doing the packet send.
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: e96a1aa6766f1b188dada3ad8d172c0fbe2f3a5f
https://github.com/qemu/qemu/commit/e96a1aa6766f1b188dada3ad8d172c0fbe2f3a5f
Author: Peter Maydell <peter.mayd...@linaro.org>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M hw/net/npcm_gmac.c
Log Message:
-----------
hw/net/npcm_gmac.c: Correct test for when to reallocate packet buffer
In gmac_try_send_next_packet() we have code that does "if this block
of data won't fit in the buffer, reallocate it". However, the
condition it uses is
if ((prev_buf_size + tx_buf_len) > sizeof(buf))
where buf is a uint8_t *.
This means that sizeof(buf) is always 8 bytes, and the condition will
almost always be true, so we will reallocate the buffer more often
than we need to.
Correct the condition to test against tx_buffer_size, which is
where we track how big the allocated buffer is.
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: a6d6e37901551cbd61b0a61c6bab5745fb1833ff
https://github.com/qemu/qemu/commit/a6d6e37901551cbd61b0a61c6bab5745fb1833ff
Author: Peter Maydell <peter.mayd...@linaro.org>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M hw/net/npcm_gmac.c
Log Message:
-----------
hw/net/npcm_gmac.c: Drop 'buf' local variable
We use the local variable 'buf' only when we call dma_memory_read(),
and it is always set to &tx_send_buffer[prev_buf_size] immediately
before both of those calls. So remove the variable and pass
tx_send_buffer + prev_buf_size to dma_memory_read().
This fixes in passing a place where we set buf = tx_send_buffer
but never used that value because we always updated buf to
something else later before using it.
Coverity: CID 1534027
Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 2ed74e3c005f236acbf7d85d396a653bfb004a17
https://github.com/qemu/qemu/commit/2ed74e3c005f236acbf7d85d396a653bfb004a17
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/passt.c
Log Message:
-----------
net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375)
The "err" variable was declared but never used within the
passt_vhost_user_event() function. This resulted in a dead code
warning (CID 1612375) from Coverity.
Remove the unused variable and the associated error block
to resolve the issue.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 37c8b208cc3161c2bcd4e2ff1e1077a64872ced3
https://github.com/qemu/qemu/commit/37c8b208cc3161c2bcd4e2ff1e1077a64872ced3
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/vhost-user.c
Log Message:
-----------
net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372)
The "err" variable was declared but never used within the
net_vhost_user_event() function. This resulted in a dead code
warning (CID 1612372) from Coverity.
Remove the unused variable and the associated error block
to resolve the issue.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: c40ef7243fdbec816242cb0ded569a61270ea7c3
https://github.com/qemu/qemu/commit/c40ef7243fdbec816242cb0ded569a61270ea7c3
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/passt.c
Log Message:
-----------
net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371)
In passt_vhost_user_start(), if vhost_net_init() fails, the "net"
variable is NULL and execution jumps to the "err:" label.
The cleanup code within this label is conditioned on "if (net)",
which can never be true in this error case. This makes the cleanup
block dead code, as reported by Coverity (CID 1612371).
Refactor the error handling to occur inline, removing the goto and
the unreachable cleanup block.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: f74e4f2e60c3b2c6e2f13eb115478df116148fe6
https://github.com/qemu/qemu/commit/f74e4f2e60c3b2c6e2f13eb115478df116148fe6
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/passt.c
Log Message:
-----------
net/passt: Check return value of g_remove() in net_passt_cleanup() (CID
1612369)
If g_remove() fails, use warn_report() to log an error.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 667ad57b7636881eb79b0b319951f3cba9bbf27e
https://github.com/qemu/qemu/commit/667ad57b7636881eb79b0b319951f3cba9bbf27e
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/passt.c
Log Message:
-----------
net/passt: Initialize "error" variable in net_passt_send() (CID 1612368)
This was flagged by Coverity as a memory illegal access.
Initialize the pointer to NULL at declaration.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: ae9b09972bbf8ff49ae0edf3241fb413391b15ce
https://github.com/qemu/qemu/commit/ae9b09972bbf8ff49ae0edf3241fb413391b15ce
Author: Laurent Vivier <lviv...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M net/vhost-user.c
Log Message:
-----------
net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365)
The "err" variable was declared but never used within the
chr_closed_bh() function. This resulted in a dead code
warning (CID 1612365) from Coverity.
Remove the unused variable and the associated error block
to resolve the issue.
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Jason Wang <jasow...@redhat.com>
Commit: 99c6e970a4a6cfd862c6bb0a363c28538436de13
https://github.com/qemu/qemu/commit/99c6e970a4a6cfd862c6bb0a363c28538436de13
Author: Thomas Huth <th...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M configure
R linux-headers/asm-arm/bitsperlong.h
R linux-headers/asm-arm/kvm.h
R linux-headers/asm-arm/mman.h
R linux-headers/asm-arm/unistd-common.h
R linux-headers/asm-arm/unistd-eabi.h
R linux-headers/asm-arm/unistd-oabi.h
R linux-headers/asm-arm/unistd.h
M scripts/update-linux-headers.sh
Log Message:
-----------
linux-headers: Remove the 32-bit arm headers
KVM support for 32-bit arm has been dropped a while ago, so we don't
need these headers in QEMU anymore.
Fixes: 82bf7ae84ce ("target/arm: Remove KVM support for 32-bit Arm hosts")
Acked-by: Cornelia Huck <coh...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Signed-off-by: Thomas Huth <th...@redhat.com>
Message-ID: <20250710120035.169376-1-th...@redhat.com>
Commit: 069a2ce8a75c9b59a4d08d6d2da3b36bfc5af3f4
https://github.com/qemu/qemu/commit/069a2ce8a75c9b59a4d08d6d2da3b36bfc5af3f4
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M tests/functional/qemu_test/testcase.py
Log Message:
-----------
functional: ensure log handlers are closed
This avoids a resource leak warning from python when the
log handler is garbage collected.
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Thomas Huth <th...@redhat.com>
Message-ID: <20250715143023.1851000-9-berra...@redhat.com>
Signed-off-by: Thomas Huth <th...@redhat.com>
Commit: 72bc0134b500d599f0f1c253c78c68df642d1634
https://github.com/qemu/qemu/commit/72bc0134b500d599f0f1c253c78c68df642d1634
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M tests/functional/test_multiprocess.py
M tests/functional/test_virtio_gpu.py
Log Message:
-----------
functional: ensure sockets and files are closed
The multiprocess and virtio_gpu tests open sockets but then forget
to close them, which triggers resource leak warnings
The virtio_gpu test also fails to close a log file it opens.
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Thomas Huth <th...@redhat.com>
Message-ID: <20250715143023.1851000-10-berra...@redhat.com>
Signed-off-by: Thomas Huth <th...@redhat.com>
Commit: c3fd296cf7b1016671205e1525e4e9caf870f68e
https://github.com/qemu/qemu/commit/c3fd296cf7b1016671205e1525e4e9caf870f68e
Author: Daniel P. Berrangé <berra...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M tests/functional/qemu_test/testcase.py
Log Message:
-----------
functional: always enable all python warnings
Of most importance is that this gives us a heads-up if anything
we rely on has been deprecated. The default python behaviour
only emits a warning if triggered from __main__ which is very
limited.
Setting the env variable further ensures that any python child
processes will also display warnings.
Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
Acked-by: Thomas Huth <th...@redhat.com>
Message-ID: <20250715143023.1851000-11-berra...@redhat.com>
Signed-off-by: Thomas Huth <th...@redhat.com>
Commit: 2c182e1213a0fd334f13948cb80b886e6fd1ab88
https://github.com/qemu/qemu/commit/2c182e1213a0fd334f13948cb80b886e6fd1ab88
Author: Alex Bennée <alex.ben...@linaro.org>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M docs/devel/testing/functional.rst
Log Message:
-----------
docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
Message-ID: <20250717104105.2656786-1-alex.ben...@linaro.org>
Signed-off-by: Thomas Huth <th...@redhat.com>
Commit: 0828b374c6568eecdb5e5389986efd99898aa822
https://github.com/qemu/qemu/commit/0828b374c6568eecdb5e5389986efd99898aa822
Author: Stefan Hajnoczi <stefa...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M hw/net/npcm_gmac.c
M net/passt.c
M net/tap.c
M net/vhost-user.c
Log Message:
-----------
Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into staging
# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEIV1G9IJGaJ7HfzVi7wSWWzmNYhEFAmh91p0ACgkQ7wSWWzmN
# YhG+2wgAqw3G2TGRPT29ObyYDcd2Z54jdnNpX5gEND/UnqENprXfdD3PR58bnxe3
# uJGPRkMXgkIDit61lshsb8DF8x9ZEIlm/Ax5FM0ksBczWDYHiyEuXoyt2Uai1kWY
# fLBkVfjFqCu1AGniboCZiC4ZawZXIqkx/+DI3J/XRqa+bSCQ18I15dsLD/yxU/pp
# Hwxp07/d+UayANdxs0mZ5Lr7a1ktTgytCt0O2jQNHlMzfOvdBbVbF/WGclMWfNgI
# 68HWPY7P8k8jRTRFx3H/0LyYQrPyseTpa3zHC+zW9jNskkPkhCwlAY4UDC8x8LII
# OjsDc/0nre626rNCiJlifD3UJ7t86A==
# =xj23
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 21 Jul 2025 01:56:45 EDT
# gpg: using RSA key 215D46F48246689EC77F3562EF04965B398D6211
# gpg: Good signature from "Jason Wang (Jason Wang on RedHat)
<jasow...@redhat.com>" [full]
# Primary key fingerprint: 215D 46F4 8246 689E C77F 3562 EF04 965B 398D 6211
* tag 'net-pull-request' of https://github.com/jasowang/qemu:
net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365)
net/passt: Initialize "error" variable in net_passt_send() (CID 1612368)
net/passt: Check return value of g_remove() in net_passt_cleanup() (CID
1612369)
net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371)
net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372)
net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375)
hw/net/npcm_gmac.c: Drop 'buf' local variable
hw/net/npcm_gmac.c: Correct test for when to reallocate packet buffer
hw/net/npcm_gmac.c: Unify length and prev_buf_size variables
hw/net/npcm_gmac.c: Send the right data for second packet in a row
tap: fix net_init_tap() return code
net/tap: drop too small packets
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Commit: 56a3033abcfcf72a2f4f1376a605a0b1ad526b67
https://github.com/qemu/qemu/commit/56a3033abcfcf72a2f4f1376a605a0b1ad526b67
Author: Stefan Hajnoczi <stefa...@redhat.com>
Date: 2025-07-21 (Mon, 21 Jul 2025)
Changed paths:
M configure
M docs/devel/testing/functional.rst
R linux-headers/asm-arm/bitsperlong.h
R linux-headers/asm-arm/kvm.h
R linux-headers/asm-arm/mman.h
R linux-headers/asm-arm/unistd-common.h
R linux-headers/asm-arm/unistd-eabi.h
R linux-headers/asm-arm/unistd-oabi.h
R linux-headers/asm-arm/unistd.h
M scripts/update-linux-headers.sh
M tests/functional/qemu_test/testcase.py
M tests/functional/test_multiprocess.py
M tests/functional/test_virtio_gpu.py
Log Message:
-----------
Merge tag 'pull-request-2025-07-21' of https://gitlab.com/thuth/qemu into
staging
* Remove unused 32-bit arm Linux headers
* Fix some small issues in the functional tests and docs
# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCgAvFiEEJ7iIR+7gJQEY8+q5LtnXdP5wLbUFAmh99uIRHHRodXRoQHJl
# ZGhhdC5jb20ACgkQLtnXdP5wLbUxsQ//XlRxmO5iChFc68yFF/zy7iVgLa5mQDws
# MeFQm5agBSRp7kK0zwb08FxE9nOzwh9OljdUUWfg858OWiHeFLiMyn85c/RM7SBn
# qovku4TfmP7TyII/czU7KbejvJvA6xrV7Adm1ltiwmV/fAueJ/RTknzY7Omy0hgV
# crRJP+xU1MWAg892QkRPrwOS1HfAsrJJs5XFkNJS9SzYhR1SSUwCGKl2qtADCUdP
# Vik88CiwMWhHiyutbsqQX1AOo+UHcNq1r+IcabqZqLed2au4sChxTq9S9xEKTLQ5
# 3QEFG2vy/QkgIpWeOkpYBQt7kQyyo0XUMECL16CY8tLaDq6/sgooSGU4WK7TxgAU
# 66GiV/VA0nJi2QkOdx9mH1BGcEjR9UMvjnvNdOUYZ2nwfg77vjHjDdI6+DFITf/W
# 3EPCKGaZBijYqsLxK2kAzM21lj+6XGXcuYnUGVWw5xte+2J4pr7LRuj1ZgWgQo8i
# qU9pS9HAz37IQumAz5ibi8/MeeyRqQkGjqyXvCL5v3PM4Ct6atgbpN0pW17GnUZ7
# oJQMxpnsie1l2VmdwbMZX8MOmnTA37AX2fMfhsjctGRtiF+Jd4XW7gAtDdsdhBtz
# I56DxTt+2oe/P35xpggH7s75Xj9k78QpWcG4HQcCxEsXNbFk0kWf6+UMCGyP1H5F
# 6kcO8zKrqBo=
# =HPaT
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 21 Jul 2025 04:14:26 EDT
# gpg: using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg: issuer "th...@redhat.com"
# gpg: Good signature from "Thomas Huth <th.h...@gmx.de>" [full]
# gpg: aka "Thomas Huth <th...@redhat.com>" [full]
# gpg: aka "Thomas Huth <h...@tuxfamily.org>" [full]
# gpg: aka "Thomas Huth <th.h...@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3 EAB9 2ED9 D774 FE70 2DB5
* tag 'pull-request-2025-07-21' of https://gitlab.com/thuth/qemu:
docs/devel: fix over-quoting of QEMU_TEST_KEEP_SCRATCH
functional: always enable all python warnings
functional: ensure sockets and files are closed
functional: ensure log handlers are closed
linux-headers: Remove the 32-bit arm headers
Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Compare: https://github.com/qemu/qemu/compare/e82989544e38...56a3033abcfc
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
