Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 4b948222c0801ddd428ca2e4260181ba35b219a3
      
https://github.com/qemu/qemu/commit/4b948222c0801ddd428ca2e4260181ba35b219a3
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M scripts/checkpatch.pl

  Log Message:
  -----------
  checkpatch: cull trailing '*/' in SPDX check

Sometimes SPDX expressions appear inside C comments, and this
confuses checkpatch.pl. Drop the closing C comment characters
to avoid this.

Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: acf7882d194562983fd7a85df5d4b99d15c81766
      
https://github.com/qemu/qemu/commit/acf7882d194562983fd7a85df5d4b99d15c81766
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M scripts/tracetool/format/c.py

  Log Message:
  -----------
  tracetool: eliminate trailing whitespace in C format

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: 69e22a5e20518fbb68b892b2189d525cf9d90a3d
      
https://github.com/qemu/qemu/commit/69e22a5e20518fbb68b892b2189d525cf9d90a3d
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M scripts/tracetool/__init__.py

  Log Message:
  -----------
  tracetool: avoid space after "*" in arg types

QEMU code style is to have no whitespace between "*" and the
arg name. Since generated trace code will soon be added to
git, make it comply with code style.

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: 52d1ec2929e5f43fe650bdbc85653e05f0aa9ffc
      
https://github.com/qemu/qemu/commit/52d1ec2929e5f43fe650bdbc85653e05f0aa9ffc
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M scripts/tracetool/format/c.py
    M scripts/tracetool/format/d.py
    M scripts/tracetool/format/h.py
    M scripts/tracetool/format/log_stap.py
    M scripts/tracetool/format/simpletrace_stap.py
    M scripts/tracetool/format/stap.py
    M scripts/tracetool/format/ust_events_c.py
    M scripts/tracetool/format/ust_events_h.py

  Log Message:
  -----------
  tracetool: include SPDX-License-Identifier in generated files

While these files are auto-generated, a later commit will add
reference output to git, so having SPDX-License-Identifier is
desirable.

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Acked-by: Thomas Huth <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: da949d495ddd4d36f2c9750eb4d70f4135018199
      
https://github.com/qemu/qemu/commit/da949d495ddd4d36f2c9750eb4d70f4135018199
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M MAINTAINERS
    M docs/devel/testing/main.rst
    M tests/Makefile.include
    M tests/meson.build
    A tests/tracetool/dtrace.c
    A tests/tracetool/dtrace.d
    A tests/tracetool/dtrace.h
    A tests/tracetool/dtrace.log-stap
    A tests/tracetool/dtrace.simpletrace-stap
    A tests/tracetool/dtrace.stap
    A tests/tracetool/ftrace.c
    A tests/tracetool/ftrace.h
    A tests/tracetool/log.c
    A tests/tracetool/log.h
    A tests/tracetool/meson.build
    A tests/tracetool/simple.c
    A tests/tracetool/simple.h
    A tests/tracetool/syslog.c
    A tests/tracetool/syslog.h
    A tests/tracetool/trace-events
    A tests/tracetool/tracetool-test.py
    A tests/tracetool/ust.c
    A tests/tracetool/ust.h
    A tests/tracetool/ust.ust-events-c
    A tests/tracetool/ust.ust-events-h

  Log Message:
  -----------
  tracetool: add test suite for tracetool with reference output

When reviewing tracetool patches it is often very unclear what the
expected output will be for the generated backends. Compounding
this is that a default build will only enable the 'log' trace
backend, so developers won't see generated code for other backends
without making a special effort. Some backends are also platform
specific, so can't be enabled in QEMU builds, even though tracetool
could generate the code.

To address this, introduce a test suite for tracetool which is
conceptually similar to the qapi-schema test. It is a simple
python program that runs tracetool and compares the actual output
to historical reference output kept in git. The test directly
emits TAP format logs for ease of integration with meson.

This can be run with

  make check-tracetool

to make it easier for developers changing generated output, the
sample expected content can be auto-recreated

  QEMU_TEST_REGENERATE=1 make check-tracetool

and the changes reviewed and added to the commit. This will also
assist reviewers interpreting the change.

Developers are reminded of this in the test output on failure:

  $ make check-tracetool
  1/6 qemu:tracetool / dtrace        OK              0.14s
  2/6 qemu:tracetool / ftrace        FAIL            0.06s   exit status 1
  ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
  1..2
  ok 1 - ftrace.c
  #
  not ok 1 - ftrace.h (set QEMU_TEST_REGENERATE=1 to recreate reference output 
if tracetool generator was intentionally changed)
  ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――

  3/6 qemu:tracetool / log           OK              0.06s
  4/6 qemu:tracetool / simple        OK              0.06s
  5/6 qemu:tracetool / syslog        OK              0.06s
  6/6 qemu:tracetool / ust           OK              0.11s

  Summary of Failures:

  2/6 qemu:tracetool / ftrace FAIL            0.06s   exit status 1

Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: c47db9b1db906bd05cf83e0d70df2beba2ef9eaf
      
https://github.com/qemu/qemu/commit/c47db9b1db906bd05cf83e0d70df2beba2ef9eaf
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M scripts/tracetool/__init__.py
    M scripts/tracetool/format/h.py
    M tests/tracetool/dtrace.h
    M tests/tracetool/ftrace.h
    M tests/tracetool/log.h
    M tests/tracetool/simple.h
    M tests/tracetool/syslog.h
    M tests/tracetool/ust.h

  Log Message:
  -----------
  tracetool: drop the probe "__nocheck__" wrapping

Every generated inline probe function is wrapped with a
trivial caller that has a hard-coded condition test:

  static inline void _nocheck__trace_test_wibble(void * context, int value)
  {
      tracepoint(qemu, test_wibble, context, value);
  }

  static inline void trace_test_wibble(void * context, int value)
  {
    if (true) {
        _nocheck__trace_test_wibble(context, value);
    }
  }

This was introduced for TCG probes back in

  864a2178: trace: [tcg] Do not generate TCG code to trace dynamically-disabled 
events

but is obsolete since

  126d4123 tracing: excise the tcg related from tracetool

This commit removes the wrapping such that we have

  static inline void trace_test_wibble(void * context, int value)
  {
      tracepoint(qemu, test_wibble, context, value);
  }

The default build of qemu-system-x86_64 on Fedora with the
'log' backend, has its size reduced by 1 MB

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: 4b1e71591254a7e924b6b295868edc6550ed0420
      
https://github.com/qemu/qemu/commit/4b1e71591254a7e924b6b295868edc6550ed0420
  Author: Daniel P. Berrangé <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M docs/devel/testing/main.rst
    M tests/qapi-schema/test-qapi.py

  Log Message:
  -----------
  qapi: switch to use QEMU_TEST_REGENERATE env var

The QAPI_TEST_UPDATE env var can be set when running the QAPI
schema tests to regenerate the reference output. For consistent
naming with the tracetool test, change the env var name to
QEMU_TEST_REGENERATE.

The test is modified to provide a hint about use of the new
env var and it is also added to the developer documentation.document its usage.

Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Daniel P. Berrangé <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: 2c27d8523927b0965b7b3d265eee3baf9a15c9c8
      
https://github.com/qemu/qemu/commit/2c27d8523927b0965b7b3d265eee3baf9a15c9c8
  Author: Marc-André Lureau <[email protected]>
  Date:   2025-09-16 (Tue, 16 Sep 2025)

  Changed paths:
    M tests/tracetool/tracetool-test.py

  Log Message:
  -----------
  tracetool-test: allow to run in parallel

Create a temporary build subdirectory, to avoid conflicting with other
running tests. This fixes "meson test" with tracetool-test which is
parallel default.

Signed-off-by: Marc-André Lureau <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Message-id: [email protected]
Message-ID: <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>


  Commit: 6be998b9863b470ab3f399f4e37cf3a9c59c8fd9
      
https://github.com/qemu/qemu/commit/6be998b9863b470ab3f399f4e37cf3a9c59c8fd9
  Author: Richard Henderson <[email protected]>
  Date:   2025-09-17 (Wed, 17 Sep 2025)

  Changed paths:
    M MAINTAINERS
    M docs/devel/testing/main.rst
    M scripts/checkpatch.pl
    M scripts/tracetool/__init__.py
    M scripts/tracetool/format/c.py
    M scripts/tracetool/format/d.py
    M scripts/tracetool/format/h.py
    M scripts/tracetool/format/log_stap.py
    M scripts/tracetool/format/simpletrace_stap.py
    M scripts/tracetool/format/stap.py
    M scripts/tracetool/format/ust_events_c.py
    M scripts/tracetool/format/ust_events_h.py
    M tests/Makefile.include
    M tests/meson.build
    M tests/qapi-schema/test-qapi.py
    A tests/tracetool/dtrace.c
    A tests/tracetool/dtrace.d
    A tests/tracetool/dtrace.h
    A tests/tracetool/dtrace.log-stap
    A tests/tracetool/dtrace.simpletrace-stap
    A tests/tracetool/dtrace.stap
    A tests/tracetool/ftrace.c
    A tests/tracetool/ftrace.h
    A tests/tracetool/log.c
    A tests/tracetool/log.h
    A tests/tracetool/meson.build
    A tests/tracetool/simple.c
    A tests/tracetool/simple.h
    A tests/tracetool/syslog.c
    A tests/tracetool/syslog.h
    A tests/tracetool/trace-events
    A tests/tracetool/tracetool-test.py
    A tests/tracetool/ust.c
    A tests/tracetool/ust.h
    A tests/tracetool/ust.ust-events-c
    A tests/tracetool/ust.ust-events-h

  Log Message:
  -----------
  Merge tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu into 
staging

Pull request

Daniel's updated tracetool test suite that doesn't break Windows CI.

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmjJo2gACgkQnKSrs4Gr
# c8gAWggAmFCi3KyeoJYLdw8ANZ46lDPV+GCtTKtCM68LtcSZKfrlNROWE/9UDI7V
# P3U/Xog01mqyWw4RX+SC90ckSWchMcLSN+TT8mZNfOTn8mcelyQkh4TDlguBLxlE
# Qz8PMwIxrKljP0bV9evZ1gk1CHkB8u1jPKLckiZRdI9rbjuxNkYTMyVSezCdfIhV
# dTDO1xf3oTDZq94591D0jSLHuF58MNXJHlA/q5OIdPCqu80Vo6cc8A8B5E1ZGKA5
# wzXaMY72GlX8RYwebXudHI0Sen6XyE3It+iWQYD8o6kgJ6kxBc0ljLxJCRE9O/d4
# D5hBgEgJ5S1ul4ggkBf5UKazF86EIQ==
# =YODs
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 16 Sep 2025 10:50:32 AM PDT
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <[email protected]>" [unknown]
# gpg:                 aka "Stefan Hajnoczi <[email protected]>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu:
  tracetool-test: allow to run in parallel
  qapi: switch to use QEMU_TEST_REGENERATE env var
  tracetool: drop the probe "__nocheck__" wrapping
  tracetool: add test suite for tracetool with reference output
  tracetool: include SPDX-License-Identifier in generated files
  tracetool: avoid space after "*" in arg types
  tracetool: eliminate trailing whitespace in C format
  checkpatch: cull trailing '*/' in SPDX check

Signed-off-by: Richard Henderson <[email protected]>


Compare: https://github.com/qemu/qemu/compare/83d5e0eedaca...6be998b9863b

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications

Reply via email to