Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 9ccd0c8a88af80f467633ca99ad7adcf513f976e
      
https://github.com/qemu/qemu/commit/9ccd0c8a88af80f467633ca99ad7adcf513f976e
  Author: John Snow <[email protected]>
  Date:   2025-11-19 (Wed, 19 Nov 2025)

  Changed paths:
    M python/scripts/mkvenv.py
    M python/setup.cfg

  Log Message:
  -----------
  python/mkvenv: ensure HAVE_LIB variables are actually constants

Pylint 4.x has refined checking for variable names that behave as
constants vs ones that do not; unfortunately our tricky import machinery
is perceived as these variables being re-assigned.

Add a temporary variable with an underscore and assign to the global
constants precisely once to alleviate this new nag message. Add an
ignore for this name for older versions of pylint that developers may
have installed locally.

(In other words: there is no solution that will cater to both pre- and
post- 4.x versions, so we target 4.x here and silence older versions.)

Signed-off-by: John Snow <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
Message-ID: <[email protected]>


  Commit: cc74a4d86e8fd848e87dc67902498cd0cd36a4aa
      
https://github.com/qemu/qemu/commit/cc74a4d86e8fd848e87dc67902498cd0cd36a4aa
  Author: John Snow <[email protected]>
  Date:   2025-11-19 (Wed, 19 Nov 2025)

  Changed paths:
    M scripts/qapi/introspect.py

  Log Message:
  -----------
  python/qapi: add an ignore for Pylint 4.x

Pylint 4.x wants to use a different regex for _Stub for some reason;
just silence this.

Signed-off-by: John Snow <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
Message-ID: <[email protected]>


  Commit: 12b4267d609afd6a56505a1982de06cdc5fd6db3
      
https://github.com/qemu/qemu/commit/12b4267d609afd6a56505a1982de06cdc5fd6db3
  Author: John Snow <[email protected]>
  Date:   2025-11-19 (Wed, 19 Nov 2025)

  Changed paths:
    M scripts/qapi/commands.py

  Log Message:
  -----------
  python/qapi: delint import statements

Missed a spot with isort, which now causes the python-minreqs test on
GitLab to fail. Fix it.

(Hint: the commands in python/tests/qapi-isort.sh can be run without the
"-c" parameter to automatically adjust import statements according to
our style rules. Maybe I should make a pre-submit hook that makes this
adjustment automatically. What do you think?)

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3200
Fixes: 5bd89761a4b ("qapi/command: Avoid generating unused  
qmp_marshal_output_T")
Signed-off-by: John Snow <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
Message-ID: <[email protected]>


Compare: https://github.com/qemu/qemu/compare/5e0242e9a847...12b4267d609a

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications

Reply via email to