Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 3de6afef49449c487256dc6238649ba0f0508789
https://github.com/qemu/qemu/commit/3de6afef49449c487256dc6238649ba0f0508789
Author: Peter Maydell <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M system/qtest.c
Log Message:
-----------
qtest: Allow and ignore blank lines in input
Currently the code that reads the qtest protocol commands insists
that every input line has a command. If it receives a line with
nothing but whitespace it will trip an assertion in
qtest_process_command().
This is a little awkward for the case where we are feeding qtest a
set of bug-reproduction commands via standard input or a file,
because it means you need to be careful not to leave a blank line at
the start or the end when cutting and pasting the command sequence
from a bug report.
Change the code to allow and ignore blank lines in the input.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Fabiano Rosas <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: ef44cc0a762438ebc84c4997a5ce29c6f00622c3
https://github.com/qemu/qemu/commit/ef44cc0a762438ebc84c4997a5ce29c6f00622c3
Author: Peter Maydell <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/pci/msix.c
M include/hw/pci/msix.h
Log Message:
-----------
hw/pci: Make msix_init take a uint32_t for nentries
msix_init() and msix_init_exclusive_bar() take an "unsigned short"
argument for the number of MSI-X vectors to try to use. This is big
enough for the maximum permitted number of vectors, which is 2048.
Unfortunately, we have several devices (most notably virtio) which
allow the user to specify the desired number of vectors, and which
use uint32_t properties for this. If the user sets the property to a
value that is too big for a uint16_t, the value will be truncated
when it is passed to msix_init(), and msix_init() may then return
success if the truncated value is a valid one.
The resulting mismatch between the number of vectors the msix code
thinks the device has and the number of vectors the device itself
thinks it has can cause assertions, such as the one in issue 2631,
where "-device virtio-mouse-pci,vectors=19923041" is interpreted by
msix as "97 vectors" and by the virtio-pci layer as "19923041
vectors"; a guest attempt to access vector 97 thus passes the
virtio-pci bounds checking and hits an essertion in
msix_vector_use().
Avoid this by making msix_init() and its wrapper function
msix_init_exclusive_bar() take the number of vectors as a uint32_t.
The erroneous command line will now produce the warning
qemu-system-i386: -device virtio-mouse-pci,vectors=19923041:
warning: unable to init msix vectors to 19923041
and proceed without crashing. (The virtio device warns and falls
back to not using MSIX, rather than complaining that the option is
not a valid value this is the same as the existing behaviour for
values that are beyond the MSI-X maximum possible value but fit into
a 16-bit integer, like 2049.)
To ensure this doesn't result in potential overflows in calculation
of the BAR size in msix_init_exclusive_bar(), we duplicate the
nentries error-check from msix_init() at the top of
msix_init_exclusive_bar(), so we know nentries is sane before we
start using it.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2631
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: a5da8dd90b9cdc308f053b2543ebf5368c12ce49
https://github.com/qemu/qemu/commit/a5da8dd90b9cdc308f053b2543ebf5368c12ce49
Author: Zhao Liu <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M docs/about/deprecated.rst
Log Message:
-----------
docs/deprecated: Remove undeprecated SMP description
"Unsupported 'parameter=1' SMP configuration" was proposed to be
deprecated in the commit 54c4ea8f3ae6 ("hw/core/machine-smp: Deprecate
unsupported "parameter=1" SMP configurations").
But the related code was reverted later in the commit 9d7950edb0cd
("hw/core: allow parameter=1 for SMP topology on any machine").
Thus, this SMP behavior is still valid and is not actually deprecated.
Remove outdated document descriptions.
Reported-by: Markus Armbruster <[email protected]>
Signed-off-by: Zhao Liu <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 622a0c9dee44f7a6c51e80644a3c5f3b132fbb7e
https://github.com/qemu/qemu/commit/622a0c9dee44f7a6c51e80644a3c5f3b132fbb7e
Author: Markus Armbruster <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/usb/bus.c
Log Message:
-----------
hw/usb: Convert to qemu_create() for a better error message
The error message changes from
open FILENAME failed
to
Could not create 'FILENAME': REASON
where REASON is the value of strerror(errno).
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 6d85f1d4492f0ef7347c488ae1d7f6f03a892573
https://github.com/qemu/qemu/commit/6d85f1d4492f0ef7347c488ae1d7f6f03a892573
Author: Markus Armbruster <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/scsi/vhost-scsi.c
Log Message:
-----------
hw/scsi: Use error_setg_file_open() for a better error message
The error message changes from
vhost-scsi: open vhost char device failed: REASON
to
Could not open '/dev/vhost-scsi': REASON
I think the exact file name is more useful to know than the file's
purpose.
We could put back the "vhost-scsi: " prefix with error_prepend(). Not
worth the bother.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 77f4f14e08184b47f1356269ae2c5db039d16af2
https://github.com/qemu/qemu/commit/77f4f14e08184b47f1356269ae2c5db039d16af2
Author: Markus Armbruster <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/virtio/vhost-vsock.c
Log Message:
-----------
hw/virtio: Use error_setg_file_open() for a better error message
The error message changes from
vhost-vsock: failed to open vhost device: REASON
to
Could not open '/dev/vhost-vsock': REASON
I think the exact file name is more useful to know than the file's
purpose.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 78d66a25c54339b370d2062826c8a011012ab6c0
https://github.com/qemu/qemu/commit/78d66a25c54339b370d2062826c8a011012ab6c0
Author: Peter Maydell <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M replay/replay-char.c
Log Message:
-----------
replay: Improve assert in replay_char_read_all_load()
In replay_char_read_all_load() we get a buffer and size from the
replay log. We know the size has to fit an int because of how we
write the log. However the way we assert this is wrong: we cast the
size_t from replay_get_array() to an int and then check that it is
non-negative. This misses cases where an over-large size is
truncated into a positive value by the cast.
Replace the assertion with checking that the size is in-range
before doing the cast.
Coverity complained about the possible overflow: CID 1643440.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 98ee8aa92e930a447c6108d4689f0bf8b535359d
https://github.com/qemu/qemu/commit/98ee8aa92e930a447c6108d4689f0bf8b535359d
Author: Peter Xu <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/core/machine.c
Log Message:
-----------
hw/core/machine: Provide a description for aux-ram-share property
It was forgotten when being introduced in commit 91792807d1 ("machine:
aux-ram-share option").
Cc: [email protected]
Reported-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Xu <[email protected]>
Reviewed-by: Fabiano Rosas <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 57756aa01fe52c50d655929c43d9a80f8214cf1a
https://github.com/qemu/qemu/commit/57756aa01fe52c50d655929c43d9a80f8214cf1a
Author: Cédric Le Goater <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M hw/misc/aspeed_xdma.c
M hw/rtc/aspeed_rtc.c
M hw/sd/aspeed_sdhci.c
Log Message:
-----------
hw/aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN
When the XDMA, RTC and SDHCI device models of the Aspeed SoCs were
first introduced, their MMIO regions inherited of a DEVICE_NATIVE_ENDIAN
endianness. It should be DEVICE_LITTLE_ENDIAN. Fix that.
Signed-off-by: Cédric Le Goater <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 9ef49528b5286f078061b52ac41e0ca19fa10e36
https://github.com/qemu/qemu/commit/9ef49528b5286f078061b52ac41e0ca19fa10e36
Author: Richard Henderson <[email protected]>
Date: 2025-11-25 (Tue, 25 Nov 2025)
Changed paths:
M docs/about/deprecated.rst
M hw/core/machine.c
M hw/misc/aspeed_xdma.c
M hw/pci/msix.c
M hw/rtc/aspeed_rtc.c
M hw/scsi/vhost-scsi.c
M hw/sd/aspeed_sdhci.c
M hw/usb/bus.c
M hw/virtio/vhost-vsock.c
M include/hw/pci/msix.h
M replay/replay-char.c
M system/qtest.c
Log Message:
-----------
Merge tag 'hw-misc-20251125' of https://github.com/philmd/qemu into staging
Misc HW patches
Few fixes in hw/; also including qtest and replay fixes.
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmkmI9YACgkQ4+MsLN6t
# wN6sSg/9EsnXLpMCfW1HyvgI67Yxb397YCvAxacPqFA+Xm9q6xCo2jKcjBnVI61A
# 4DkSsYC7OE2wdRzzziiWaXEfydGKHa7rXNGdunYSY52XLk2oElhSS0ykPsUWeFS+
# 66+YzSgNgBKHIdDHSVRgoTPDOYW6LSLU+Zfbj40FfApnuRw8AFRB+qVQaXvCV8h/
# W6fI4B2ce/0Rv8o0AJDWnN3HP6rZZ+l+eyhj9ODPusAC+OU4nowiJBCoCJa8GwDY
# KiASI9+mA4jY2vcoCiXG4Bbg1VzOte2TKudZwTwvhqkmGh0S6VejqO/Pn6IKh3j0
# H3YrXMDn6h4GrJ3gd3YTseeuEhApYnUP76MWuPy+MjMwp605rMCh/voVkzRvBdmn
# xXzklO48hpk8cRD3W4kfvJIlrBZIrMSFG8Q4m6S9FXZkGUP9zm2bOCkRqMxfdEdI
# H1/J/sJ5iPOIwd87yElSV16i9BZyalcWZDYkQLKgtroq1uPaGxUR46mlnhMFKeBP
# 68Xjh9ux6zOuFwb4FIqbEyyKTMVdGrkHuD267YHEKQo0X0frGjFfdRtrW3zJbMIw
# vAFsQl2oPAKJ7DpEHae/CeD10piQRb/nTav9UdscaXoIUJdFJ+nPfHNwUkKW30Gw
# SSmueD2qJcqwzVa36SRhYxwG5+EW2RsN1kL5wkHv3qhRaoEfKJ8=
# =hq47
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 25 Nov 2025 01:47:02 PM PST
# gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <[email protected]>"
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE
* tag 'hw-misc-20251125' of https://github.com/philmd/qemu:
hw/aspeed/{xdma, rtc, sdhci}: Fix endianness to DEVICE_LITTLE_ENDIAN
hw/core/machine: Provide a description for aux-ram-share property
replay: Improve assert in replay_char_read_all_load()
hw/virtio: Use error_setg_file_open() for a better error message
hw/scsi: Use error_setg_file_open() for a better error message
hw/usb: Convert to qemu_create() for a better error message
docs/deprecated: Remove undeprecated SMP description
hw/pci: Make msix_init take a uint32_t for nentries
qtest: Allow and ignore blank lines in input
Signed-off-by: Richard Henderson <[email protected]>
Compare: https://github.com/qemu/qemu/compare/a8d023be622c...9ef49528b528
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
