> On 29/09/2017 10:58, Philippe Mathieu-Daudé wrote:
> > Hi Jiang,
> > 
> > I'm not sure it is really helpful to remove those comment, they are here as
> > debt to the project, reminding what should be implemented.
> > 
> > Are you proposing to accept this instructions will never get implemented?
> > 
> > Regards,
> > 
> > Phil.
>> 
> 
> Hi Phil,
> 
> The commented codes are all trivial. When the time we implement those
> features it is merely copy & paste from the specification. I don't think
> there is much harm to remove the comments.
> Besides there is TODO file in the same directory but that has not been
> updated for a while, perhaps updating the file is much relevant with this
> patch.
Can't agree more :), it should be better put the reminder in other place 


rather in release code.




Regards,

Jiang

Reply via email to