David Hildenbrand <[email protected]> writes: > CPU hotplug is only possible on a per core basis on s390x. So let's > add possible_cpus and properly wire everything up. > > Signed-off-by: David Hildenbrand <[email protected]> [...] > diff --git a/qapi-schema.json b/qapi-schema.json > index f3af2cb851..79e9f85404 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3121,6 +3121,22 @@ > # } > # ]} > # > +# For s390x-virtio-ccw machine type started with -smp 1,maxcpus=2 -cpu qemu > +# (Since: 2.11): > +# > +# -> { "execute": "query-hotpluggable-cpus" } > +# <- {"return": [ > +# { > +# "type": "qemu-s390-cpu", "vcpus-count": 1, > +# "props": { "core-id": 1 } > +# }, > +# { > +# "qom-path": "/machine/unattached/device[0]", > +# "type": "qemu-s390-cpu", "vcpus-count": 1, > +# "props": { "core-id": 0 } > +# } > +# ]} > +# > ## > { 'command': 'query-hotpluggable-cpus', 'returns': ['HotpluggableCPU'] }
Please stick in '# Example:' like we do in query-hotpluggable-cpus's doc comment. I expect the generated documentation to be illegible[*] without it. [*] If you want to perform a quick eye-over, try running "make tests/qapi-schema/doc-good.test.txt" and examine the result.
