On Mon, Oct 02, 2017 at 12:19:54PM +0100, Peter Maydell wrote: > On 2 October 2017 at 12:17, Daniel P. Berrange <[email protected]> wrote: > > On Mon, Oct 02, 2017 at 12:14:39PM +0100, Peter Maydell wrote: > >> Why does this executable need to define its own link rule anyway? > >> Ideally it should just use the standard rules.mak LINK function > >> like everything else. If it does need to do something weird > >> it should have a comment saying why it's weird... > > > > Primarily because we're static linking this binary so that it can be put > > into an initrd without needing any extra files added. It doesn't use any > > of the 3rd party libraries the rest of QEMU uses - ie no glib2 in > > particular. > > Oh, are we committing our usual error of trying to build guest > binaries with the host toolchain?
That's not an error here - this test suite is only intended to run with matching host/guest arch, and boots with the host kernel + custom initrd containing only this binary. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
