Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PULL 0/3] QAPI patches for 2017-10-02 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 0915be50ad watchdog: Allow setting action on the fly 44e77bbf9d watchdog.h: Drop local redefinition of actions enum 8fcd8a0f85 qapi: Rename WatchdogExpirationAction enum === OUTPUT BEGIN === Checking PATCH 1/3: qapi: Rename WatchdogExpirationAction enum... Checking PATCH 2/3: watchdog.h: Drop local redefinition of actions enum... ERROR: braces {} are necessary for all arms of this statement #57: FILE: hw/watchdog/watchdog.c:86: + if (action < 0) [...] total: 1 errors, 0 warnings, 130 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: watchdog: Allow setting action on the fly... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
