On 29/09/2017 21:31, Eduardo Habkost wrote: >> -void DMA_init(ISABus *bus, int high_page_enable) >> +void DMA_init(ISABus *bus, int high_page_enable, Error **errp) > > If you make the function return a boolean to indicate success (in > addition to setting *errp), you avoid the need for a local_err > variable on the caller.
I think in this case, rather than a bool, it would be better to return 0 or -EBUSY. A check for "< 0" would be more self-explanatory in the caller. Paolo
