On Monday 04 September 2006 14:01, Christophe Fillot wrote:
> Peter Oberndorfer a e'crit :
> >
> >
> > if (info->sign) {
> > - memset (buf, 0x00, len << info->shift);
> > + memset (buf, len << info->shift, 0x00);
> > }
> > else {
> > if (info->bits == 8) {
> > - memset (buf, 0x80, len << info->shift);
> > + memset (buf, len << info->shift, 0x80);
> > }
> >
> >
> > This part looks wrong (swapped parameters)
> >
>
> Hello,
>
> No, this is correct:
>
> #include <string.h>
>
> void *memset(void *s, int c, size_t n);
"The memset() function fills the first n bytes of the memory area pointed to by
s with the constant byte c."
But isn't a size of 0x00 bytes a bit pointless?
Or is this a reverse patch? (doesn't look like one)
>
> Best regards.
Greetings Peter
_______________________________________________
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
