On Sun, 24 Sep 2006, Blue Swirl wrote:
After having a cursory look at it only one thing really caught my
attention:
in the audio callback you set s->audio_free to the provided value, but then
in you never use it. If i'm reading everything correctly this would lead to
reading N bytes from DMA in write_audio, succeeding in writing only M bytes
(where M < N) to the audio subsystem and loosing N-M bytes forever.
Basically
you should never attempt to do volatile reads of more than audio_free
bytes.
SB16 operates in similar fashion.
Okay, thanks for the clarification.
By the way, I couldn't find where AUD_open_out is implemented, what did I
miss?
audio/audio_template.h (since code is mostly the same for in and out)
--
mailto:[EMAIL PROTECTED]
_______________________________________________
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
