Hi, of course comments are welcome! And yes, you're right about all of them. we will fix it ASAP.
In other hand, we don't expect to do this plugin official to QEMU. we think it's too specific and it's useless to "normal" qemu user. By the way, I'd like ask to mailing list if people think it's good enough to make this work official inside QEMU. Thanks for suggestions and answers! Màrius Johannes Schindelin wrote: > Hi, > > On Wed, 22 Nov 2006, Màrius Montón wrote: > > >> Our work on SystemC + QEMU has been published: >> http://cephis.uab.es/proj/public/qemu/ >> > > Great! > > A few comments (as you said they are welcome): > > - As far as I saw, you use C++, but the code is simple enough to be > written in C. This is needed by SystemC, correct? > > - the c++ compiler is typically called CXX, not CC2, in Makefiles > > - your diff contains changes to arm-user/Makefile and likewise for other > targets. These Makefiles are just copies of Makefile.target; you should > patch only this. > > - there are backup files in your patch > > - some namings are non-English ("llegir", "escriure"). Please use the > English terms "read" and "write" instead > > - (minor nit) the indentation of hw/pc.c is incorrect > > - (minor nit) the file names and function names in QEmu are lower case > ("SCLink.c", "SC_init()") > > - since the SystemC code is not target specific (or is it?), you could > have it in its own subdirectory, like the audio/ stuff > > - this code depends on SystemC being present, right? You should add a > configure option, and disable this code (including CXX linking) if the > option was not passed -- there are probably many more users without the > necessary dependencies > > - if you want to submit it to the list, you can do so as an attached > gzipped patch > > Ciao, > Dscho > > > ------------------------------------------------------------------------ > > _______________________________________________ > Qemu-devel mailing list > Qemu-devel@nongnu.org > http://lists.nongnu.org/mailman/listinfo/qemu-devel > -- Màrius Montón i Macián [EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> http://cephis.uab.es <http://www.mariusmonton.name> Hardware Engineer CEPHIS Centre de Prototips i Solucions Hardware-Software Dep. Microelectrònica i Sistemes Electrònics ETSE - Universitat Autònoma de Barcelona (UAB) Phone: +34 935 813 534 Fax: +34 935 813 033 QC-2090D. ETSE. Campus UAB. 080193 Bellaterra
begin:vcard fn;quoted-printable:M=C3=A0rius Mont=C3=B3n n;quoted-printable;quoted-printable:Mont=C3=B3n;M=C3=A0rius org;quoted-printable:CEPHIS;Microelectr=C3=B2nica i Sistemes Electronics adr:Campus de la UAB;;QC-2090D, ETSE;Bellaterra;Barcelona;08193;Spain email;internet:[EMAIL PROTECTED] title:HW Engineer tel;work:+34935813534 tel;fax:+34935813033 x-mozilla-html:TRUE url:http://cephis.uab.es version:2.1 end:vcard
_______________________________________________ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel
