Bernhard Fischer wrote:
Hi,
The attached patch moves the x_keycode_to_pc_keycode LUT from sdl.c into
an x_keycode.c. This struct is also used by the GGI backend (that is not
yet merged ¹).
Comments?
How it is done right now, each time x_keycode.c is included, you will
end up with an extra copy in the final executable. Perhaps that simply
keeping the LUT in sdl.c but removing the 'static' keyword from it and
creating a sdl.h file with the statement:
extern const uint8_t *x_keycode_to_pc_keycode;
would be a better idea. Including a header file is more clean than
including a C file as well.
Please apply.
¹)
http://members.aon.at/berny_f/qemu/qemu-HEAD.ggi-2.2.x-04c-20070104.diff
_______________________________________________
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
_______________________________________________
Qemu-devel mailing list
Qemu-devel@nongnu.org
http://lists.nongnu.org/mailman/listinfo/qemu-devel
