On Thu, Jan 04, 2007 at 07:21:40PM +0000, Paul Brook wrote: >On Thursday 04 January 2007 15:02, Bernhard Fischer wrote: >> Hi, >> >> This patchlet adds a check to configure that makes sure that we have a >> working alsa setup. >> >> Previously, if --enable-alsa was given but the user forgot to install >> the alsa libs proper, the build failed later on due to eventually >> missing libs. The patch makes sure that the user can spot that alsa >> support was turned off after configuration completed. > >This is wrong. If the user requests alsa we should honour that request, or >fail trying. We should never quietly ignore an explicit user decision. > >Making configure fail early with an error is acceptable (as it the current >link failure). Ignoring --enable-alsa is not.
Fair enough. Updated variant prints an error if the compile-check failed.
--- ../qemu_trunk.orig/configure 2007-01-04 14:38:58.000000000 +0100 +++ configure 2007-01-04 20:46:22.000000000 +0100 @@ -509,6 +536,25 @@ fi # sdl compile test fi # cross compilation fi # -z $sdl +########################################## +# sound support libraries +# alsa +if test "$alsa" = "yes" ; then + cat > $TMPC << EOF +#include <alsa/asoundlib.h> +int main(void) { snd_pcm_t **handle; return snd_pcm_close(*handle); } +EOF + if $cc -o $TMPE $TMPC -lasound 2> /dev/null ; then + : + else + echo + echo "Error: Could not find alsa" + echo "Make sure to have the alsa libs and headers installed." + echo + exit 1 + fi +fi # alsa + # Check if tools are available to build documentation. if [ -x "`which texi2html`" ] && [ -x "`which pod2man`" ]; then build_docs="yes"
_______________________________________________ Qemu-devel mailing list Qemu-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/qemu-devel