On 04.03.2012, at 22:19, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote:
> On Sun, 2012-03-04 at 21:59 +0100, Alexander Graf wrote: >>>>> g_assert(TARGET_PAGE_SIZE <= getpagesize()) >>>>> >>>>> Just declare the above case as unsupported and abort if we >> encounter it. >>>> >>>> What I'm trying to tell you is that it's the default case on book3s >> ppc! ;) >>> >>> Exactly, which is why I'm saying just ignore the weird embedded >> case. :) >> >> Ugh. Sorry, apparently I can't read :). So you're saying 'break for >> ppcemb'. Hrm. Not sure that'd be all that great for 440, since there >> host pagesize is still 4k, but T_P_S is 1k. > > No, Alex, you are reading Andreas assert backward :-) > > What he suggests is "break if TARGET_PAGE_SIZE > getpagesize()" which > currently cannot happen. Even embedded 1k TARGET_PAGE_SIZE is fine. It's > getpagesize() 1k that wouldn't be but it also never happens. O_o. Ok, that would obviously work. We never get hostpagesize <4k and T_P_S is always 1k/4k, never bigger. Alex > > Cheers, > Ben. > >
