I was debating what to add. I couldn't find a project-wide template for what the header should be and I couldn't copy/paste from where I copied the code from (virt.c) because it names a specific author that I'm not sure wrote this code... Any advice?
On Mon, Oct 30, 2023 at 9:52 AM Stefan Berger <stef...@linux.ibm.com> wrote: > > > On 10/29/23 02:03, Joelle van Dyne wrote: > > TPM needs to know its own base address in order to generate its DSDT > > device entry. > > > > Signed-off-by: Joelle van Dyne <j...@getutm.app> > > --- > > include/sysemu/tpm.h | 4 ++++ > > hw/tpm/tpm-sysbus.c | 33 +++++++++++++++++++++++++++++++++ > > hw/tpm/meson.build | 1 + > > 3 files changed, 38 insertions(+) > > create mode 100644 hw/tpm/tpm-sysbus.c > > > > diff --git a/include/sysemu/tpm.h b/include/sysemu/tpm.h > > index 1ee568b3b6..ffd300e607 100644 > > --- a/include/sysemu/tpm.h > > +++ b/include/sysemu/tpm.h > > @@ -12,6 +12,8 @@ > > #ifndef QEMU_TPM_H > > #define QEMU_TPM_H > > > > +#include "qemu/osdep.h" > > +#include "exec/hwaddr.h" > > #include "qapi/qapi-types-tpm.h" > > #include "qom/object.h" > > > > @@ -78,6 +80,8 @@ static inline TPMVersion tpm_get_version(TPMIf *ti) > > return TPM_IF_GET_CLASS(ti)->get_version(ti); > > } > > > > +void tpm_sysbus_plug(TPMIf *tpmif, Object *pbus, hwaddr pbus_base); > > + > > #else /* CONFIG_TPM */ > > > > #define tpm_init() (0) > > diff --git a/hw/tpm/tpm-sysbus.c b/hw/tpm/tpm-sysbus.c > > new file mode 100644 > > index 0000000000..ef0592b837 > > --- /dev/null > > +++ b/hw/tpm/tpm-sysbus.c > > @@ -0,0 +1,33 @@ > > A header in this new file would be good. Otherwise LGTM. > > Stefan > > > +#include "sysemu/tpm.h" > > +#include "hw/platform-bus.h" > > +#include "hw/sysbus.h" > > +#include "qapi/error.h" > > >
