>-----Original Message----- >From: Cédric Le Goater <c...@redhat.com> >Sent: Monday, October 30, 2023 9:52 PM >Subject: Re: [PATCH v3 27/37] vfio/iommufd: Switch to manual hwpt allocation > >On 10/26/23 12:30, Zhenzhong Duan wrote: >> IOMMUFD supports auto allocated hwpt and manually allocated one. >> Manually allocated hwpt has benefit that its life cycle is under >> user's control, so it could be used as stage 2 page table by nested >> feature in the future. > >Would an option be useful to switch from one mode to another ?
Looks unnecessary for me as we prefer manual allocation. The purpose of splitting is to make review easier. > >> >> Introduce two helpers __vfio_device_attach/detach_hwpt to facilitate >> this change. > >I think merging this change with the previous patch makes sense. >It doesn't add much to keep it as a standalone patch unless we >want a feature toggle. OK, will merge them in v4. Thanks Zhenzhong
