On 2023/10/31 3:52, Zhang, Chen wrote:
-----Original Message-----
From: qemu-devel-bounces+chen.zhang=intel....@nongnu.org <qemu-
devel-bounces+chen.zhang=intel....@nongnu.org> On Behalf Of Akihiko
Odaki
Sent: Monday, October 30, 2023 1:12 PM
Cc: qemu-devel@nongnu.org; Yuri Benditovich
<yuri.benditov...@daynix.com>; Andrew Melnychenko
<and...@daynix.com>; Michael S . Tsirkin <m...@redhat.com>; Jason Wang
<jasow...@redhat.com>; Akihiko Odaki <akihiko.od...@daynix.com>
Subject: [PATCH v6 05/21] tap: Remove tap_receive()
The receive member of NetClientInfo is only for legacy clients and the
receive_iov member is always used when it is set.
Under normal circumstances we still need to maintain compatibility.
It seems that there is no need to remove the tap_receive here.
You just need to optimize the tap_receive to call the tap_receive_iov.
In the history, we can see a large number of devices still keep this interface,
For example, e1000_receive can directly call the e1000_receive_iov.
That sounds a good idea. I'll do so in the next version.
Regards,
Akihiko Odaki
