Philippe Mathieu-Daudé <phi...@linaro.org> writes: > Hi Markus, > > On 30/10/23 14:37, Markus Armbruster wrote: >> Zero @length is rejected with "Invalid parameter 'length'". Improve >> to "Parameter 'length' expects a non-zero length". >> >> @protocol values not starting with "fd:" or "file:" are rejected with >> "Invalid parameter 'protocol'". Improve to "parameter 'protocol' must >> start with 'file:' or 'fd:'". >> >> While there, make the conditional checking @protocol a little more >> obvious. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> dump/dump.c | 16 +++++++--------- >> 1 file changed, 7 insertions(+), 9 deletions(-) >> diff --git a/dump/dump.c b/dump/dump.c >> index a5e9a06ef1..d888e4bd3c 100644 >> --- a/dump/dump.c >> +++ b/dump/dump.c >> @@ -1812,7 +1812,8 @@ static void dump_init(DumpState *s, int fd, bool >> has_format, >> s->fd = fd; >> if (has_filter && !length) { >> - error_setg(errp, QERR_INVALID_PARAMETER, "length"); >> + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "length", > > Per commit 4629ed1e98 ("qerror: Finally unused, clean up", 2015): > > /* > * These macros will go away, please don't use in new code, ... > > Instead we can use: > > error_setg(errp, "Parameter '%s' expects %s", "length",
I left this to the next version of your "qapi: Kill 'qapi/qmp/qerror.h' for good" out of laziness. Since you prefer the deed to be done right away, I will in v2. >> + "a non-zero size"); >> goto cleanup; >> }