(+cc qemu-devel) On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote: > Qemu's SCLP implementation incorrectly reports that it supports CPU > reconfiguration. If a guest issues a CPU reconfiguration request it > is rejected as invalid command. > > Fix the SCLP_HAS_CPU_INFO mask, and remove the unused > SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines. > > Reviewed-by: Eric Farman <far...@linux.ibm.com> > Reviewed-by: Halil Pasic <pa...@linux.ibm.com> > Signed-off-by: Heiko Carstens <h...@linux.ibm.com> > --- > include/hw/s390x/sclp.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)
Thomas, any concerns? Could this get picked up for 8.2, please? > > diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h > index 9aef6d937012..b4ecd04e2341 100644 > --- a/include/hw/s390x/sclp.h > +++ b/include/hw/s390x/sclp.h > @@ -38,10 +38,8 @@ > #define MAX_STORAGE_INCREMENTS 1020 > > /* CPU hotplug SCLP codes */ > -#define SCLP_HAS_CPU_INFO > 0x0C00000000000000ULL > +#define SCLP_HAS_CPU_INFO > 0x0800000000000000ULL > #define SCLP_CMDW_READ_CPU_INFO 0x00010001 > -#define SCLP_CMDW_CONFIGURE_CPU 0x00110001 > -#define SCLP_CMDW_DECONFIGURE_CPU 0x00100001 > > /* SCLP PCI codes */ > #define SCLP_HAS_IOA_RECONFIG > 0x0000000040000000ULL
