On Thu, Nov 09, 2023 at 06:03:15PM +0000, Peter Maydell wrote: > On Thu, 9 Nov 2023 at 17:53, Michael S. Tsirkin <m...@redhat.com> wrote: > > > > On Thu, Nov 09, 2023 at 04:25:04PM +0000, Peter Maydell wrote: > > > On Thu, 9 Nov 2023 at 16:21, Manos Pitsidianakis > > > <manos.pitsidiana...@linaro.org> wrote: > > > > > > > > AUD_register_card might fail. Even though errp was passed as an > > > > argument, the call's return value was not checked for failure. > > > > > > For whoever picks up this patch: we can add > > > "Fixes Coverity CID 1523899" to the commit message. > > > > > > Better: > > > > Fixes: Coverity CID 1523899 > > I thought "Fixes:" as a header-line like that was for > the commit hash/subject of the commit the patch is fixing? > > thanks > -- PMM
This works for many other things e.g. gitlab issues (closes them). Fixes without : is much harder to distinguish from just general english text. qemu uses a mix of Fixes: Resolves: and Closes: . I don't see a real need for distinct tags for commit versus gitlab issue link: one can look at the contents to figure that out. -- MST
