On 7 March 2012 11:38, Gerd Hoffmann <kra...@redhat.com> wrote: > But it still doesn't build indeed. > Looks like new warnings sneaked in ...
Actually I get an outright compile error: CC ui/spice-display.o ui/spice-display.c: In function ‘qemu_spice_add_memslot’: ui/spice-display.c:79:42: error: ‘QXL_IO_MEMSLOT_ADD_ASYNC’ undeclared (first use in this function) ui/spice-display.c:79:42: note: each undeclared identifier is reported only once for each function it appears in ui/spice-display.c: In function ‘qemu_spice_create_primary_surface’: ui/spice-display.c:97:42: error: ‘QXL_IO_CREATE_PRIMARY_ASYNC’ undeclared (first use in this function) ui/spice-display.c: In function ‘qemu_spice_destroy_primary_surface’: ui/spice-display.c:110:42: error: ‘QXL_IO_DESTROY_PRIMARY_ASYNC’ undeclared (first use in this function) make: *** [ui/spice-display.o] Error 1 git bisect blames commit 2e1a98c9c "qxl: introduce QXLCookie". Do we need a preprocessor guard so we don't try to use these if the host's spice headers don't support them? (My host is Ubuntu Oneiric with libspice-server-dev 0.8.2-2 and spice-protocol-dev 0.8.0-0ubuntu1.) -- PMM
