Hi Alex,
On 27/6/23 18:09, Alex Bennée wrote:
The old g_memdup is deprecated, use the replacement.
Message-Id: <20230623122100.1640995-21-alex.ben...@linaro.org>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
---
contrib/plugins/lockstep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c
index e36f0b9562..3614c3564c 100644
--- a/contrib/plugins/lockstep.c
+++ b/contrib/plugins/lockstep.c
@@ -130,7 +130,7 @@ static void report_divergance(ExecState *us, ExecState
*them)
}
}
divergence_log = g_slist_prepend(divergence_log,
- g_memdup(&divrec, sizeof(divrec)));
+ g_memdup2(&divrec, sizeof(divrec)));
Actually I missed g_memdup2() is GLib >= 2.68. For QEMU codebase we
define it in include/glib-compat.h, but contrib/ files don't include
that.
So on Ubuntu 20.04 LTS we get:
contrib/plugins/lockstep.c:133:38: error: implicit declaration of
function 'g_memdup2' is invalid in C99
[-Werror,-Wimplicit-function-declaration]
133 | g_memdup2(&divrec,
sizeof(divrec)));
| ^~~~~~~~~
| g_memdup
/* Output short log entry of going out of sync... */
if (verbose || divrec.distance == 1 || diverged) {
