Hi Thomas, On Mon, Dec 04, 2023 at 10:07:12AM +0100, Thomas Huth wrote: > Date: Mon, 4 Dec 2023 10:07:12 +0100 > From: Thomas Huth <th...@redhat.com> > Subject: Re: [RFC 1/3] scripts/checkpatch: Check common spelling be default > > On 04/12/2023 09.29, Zhao Liu wrote: > > From: Zhao Liu <zhao1....@intel.com> > > > > Add the check for common spelling mistakes for QEMU, which stole > > selling.txt from Linux kernel and referenced the Linux kernel's > > You need to sellcheck^Wspellcheck the above line ;-)
Oh no, I didn't expect this place to be wrong...--codespelling isn't infallible! > > > implementation in checkpatch.pl. > > > > This check covers common spelling mistakes, and can be updated/ > > extended as per QEMU's realities. > > > > Signed-off-by: Zhao Liu <zhao1....@intel.com> > > --- > > scripts/checkpatch.pl | 44 ++ > > scripts/spelling.txt | 1713 +++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 1757 insertions(+) > > create mode 100644 scripts/spelling.txt > > I like the idea of having spellchecking in checkpatch.pl Thanks! > ... not sure though > if we need both, this patch and support for codespell. If you ask me, I'd > just go with the next codespell patch and avoid adding a full spelling.txt > file here ... but if others like this patch here, too, I'm also fine with > it. OK, I'll wait a few days to see if anyone else has any comments, if not I'll refresh a V2 and just keep the next patch. Regards, Zhao
