On Fri, Mar 9, 2012 at 2:09 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 09.03.2012 14:20, schrieb Stefan Hajnoczi: >> On Fri, Mar 9, 2012 at 12:46 PM, Kevin Wolf <kw...@redhat.com> wrote: >>> Run the 'quick' group from qemu-iotests during 'make check'. >>> >>> Signed-off-by: Kevin Wolf <kw...@redhat.com> >>> --- >>> tests/Makefile | 5 +++++ >>> tests/qemu-iotests-quick.sh | 17 +++++++++++++++++ >>> 2 files changed, 22 insertions(+), 0 deletions(-) >>> create mode 100755 tests/qemu-iotests-quick.sh >>> >>> diff --git a/tests/Makefile b/tests/Makefile >>> index 74b29dc..571ad42 100644 >>> --- a/tests/Makefile >>> +++ b/tests/Makefile >>> @@ -1,6 +1,9 @@ >>> +export SRC_PATH >> >> I'm not sure I like this. Could we avoid this with: >> >> cd $(dirname "$0")/tests/qemu-iotests >> >> instead of using SRC_PATH in qemu-iotests-quick.sh? > > Do you really like this better? To me it doesn't feel cleaner.
It makes qemu-iotests-quick.sh self-contained instead of relying on a magic environment variable. That's why I like it better. But it's not critical :). Stefan
