On Thu, 14 Dec 2023 at 11:43, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Mon, 11 Dec 2023 at 17:52, Nabih Estefan <nabiheste...@google.com> wrote: > > > > From: Nabih Estefan Diaz <nabiheste...@google.com> > > > > [Changes since v6] > > Remove the Change-Ids from the commit messages. > > > > This doesn't compile: > > ../../hw/net/npcm_gmac.c:889:43: error: too few arguments to function > call, expected 6, have 5 > dev->id, gmac); > ^ > /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/include/net/net.h:159:11: > note: 'qemu_new_nic' declared here > NICState *qemu_new_nic(NetClientInfo *info, > ^ > 1 error generated. > > Please make sure you've rebased the series on the most > recent head-of-git. (In this case you are missing the > necessary changes to cope with commit 7d0fefdf81f5 > which added an extra argument to this function.)
Also, when you're resending please check your cc list. You have had a typo in Jason Wang's email address for I think every version of this series, which means when I hit 'reply all' I get a bounce message. The email address in MAINTAINERS for him has the correct spelling. thanks -- PMM
