On 03/09/2012 12:20 PM, Jan Kiszka wrote:
On 2012-03-09 19:13, Luiz Capitulino wrote:
The Monitor object is passed back and forth within the migration/savevm
code so that it can print errors and progress to the user.
However, that approach assumes a HMP monitor, being completely invalid
in QMP.
This commit drops almost every single usage of the Monitor object, all
monitor_printf() calls have been converted into DPRINTF() ones.
I guess for most printfs, this is OK. But do you provide an alternative
for the block migration progress output? I did not find anything on
first glance. That is not a debugging feature.
The block migration progress stuff is horribly broken and I regret ever merging
it. Are you actively relying on this?
Does block migration even work?
Could we just remove block migration entirely...
Regards,
Anthony Liguori
Jan
