On Mon, 18 Dec 2023 at 18:34, Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > On 12/18/23 14:53, Peter Maydell wrote: > > On Mon, 18 Dec 2023 at 17:22, Daniel Henrique Barboza > > <dbarb...@ventanamicro.com> wrote: > > We don't seem to worry about that in any of the other > > KVM code -- accel/kvm/ has lots of places that > > use strerror() or error_setg_errno(). > > I don't know how this is being used in other parts of accel/kvm, but in this > particular > instance we're handling the errors from get_one_reg.
Yep; compare accel/kvm/kvm-all.c:kvm_get_one_reg(), which does: r = kvm_vcpu_ioctl(cs, KVM_GET_ONE_REG, ®); if (r) { trace_kvm_failed_reg_get(id, strerror(-r)); } -- PMM