Am 19.12.2023 um 16:13 hat Stefan Hajnoczi geschrieben: > On Sat, Oct 14, 2023 at 09:35:14AM +0200, Markus Armbruster wrote: > > Stefan Hajnoczi <stefa...@redhat.com> writes: > > > +## > > > +# @IOThreadVirtQueueMappings: > > > +# > > > +# IOThreadVirtQueueMapping list. This struct is not actually used but the > > > +# IOThreadVirtQueueMappingList type it generates is! > > > > Two spaces between sentences for consistency, please. > > > > Doc comments are QMP reference documentation for users. Does this > > paragraph belong there? > > Someone might wonder why a type exists that is never used, so I think > including this in the documentation is acceptable.
I seem to remember that we had a similar remark elsewhere, but maybe it doesn't exist any more today? > My comment is mostly intended to stop someone from removing this > "unused" type from the schema though. If there is a better way to do > that I can do that instead. Won't the QAPI generator or the compiler stop them soon enough? Kevin
signature.asc
Description: PGP signature
