On Tue, 19 Dec 2023 at 19:15, Samuel Tardieu <s...@rfc1149.net> wrote: > > > Peter Maydell <peter.mayd...@linaro.org> writes: > > >> Any idea to why patchew fails to apply thoses patches? The mbox > >> at > >> <https://patchew.org/QEMU/20231216182740.3305724-1-...@rfc1149.net/> > >> applies cleanly on master AFAICS. > > > > This is because you put a Based-on: tag in the cover letter. > > Based-on: means "please apply this other patch first before this > > series, because there is a dependency" (we use it for things > > like "this patchset has to sit on top of some other cleanup > > patchset I sent last week and which hasn't got into git yet"). > > So patchew applied Anton's original patch from 2022, and then > > tried > > to apply your three patches on top of that, which caused a > > conflict. > > Thanks for the explanation. I thought "Based-on:" was just a > polite way of attributing credit to past discussions. I'll keep > that in mind. Do you want me to resubmit it as a v2 without the > "Based-on:" tag so that patchew gets it right?
No, you don't need to do that. I can review it, and if it's OK I can apply it to my target-arm tree, based on what we have now. thanks -- PMM