On 12/23/23 05:15, Paolo Bonzini wrote:
X86_SPECIAL_ZExtOp0 and X86_SPECIAL_ZExtOp2 are poorly named; they are a hack
that is needed by scalar insertion and extraction instructions, and not really
related to zero extension: for PEXTR the zero extension is done by the 
generation
functions, for PINSR the high bits are not used at all and in fact are*not*
filled with zeroes when loaded into s->T1.

Rename the values to match the effect described in the manual, and explain
better in the comments.

Signed-off-by: Paolo Bonzini<pbonz...@redhat.com>
---
  target/i386/tcg/decode-new.c.inc | 16 ++++++++--------
  target/i386/tcg/decode-new.h     | 17 +++++++++++++----
  2 files changed, 21 insertions(+), 12 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

r~

Reply via email to