This patch adds a new device STM32L4x5 EXTI device and is part of a series implementing the STM32L4x5 with a few peripherals.
Hello, I see that the previous patch v7 couldn't be applied to master, the log is : ... Applying: hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC error: sha1 information is lacking or useless (hw/arm/stm32l4x5_soc.c). error: could not build fake ancestor ... I notice there was a wrong Based-on message ID in v7 and I figure that's the issue (since the relevant commit "hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC" didn't even change from v6). If that's not the case, I apologize in advance. Changes from v7 to v8: - none except for "Based-on" message-id correction Changes from v6 to v7: - in `stm32l4x5_exti_reset_hold`: unify register initialization using new array `exti_romask` - in `stm32l4x5_exti_set_irq`: rename `n` to `bank`, use new helper function `regbank_index_by_irq` and new macro `EXTI_MAX_IRQ_PER_BANK`, explain why there's no `else` clause - in `stm32l4x5_exti_read`: rename `n` to `bank`, use new helper function `regbank_index_by_irq`, use `HWADDR_PRIx` formatting in error log - in `stm32l4x5_exti_write`: rename `n` to `bank`, use new helper function `regbank_index_by_irq`, use `HWADDR_PRIx` formatting in error log, unify writes where only bank differs using new helper functions `valid_mask` and `configurable_mask` - in `stm32l4x5_exti_init`: use `size_t` instead of `int` in for loop - in `stm32l4x5_exti-test.c`: instead of declaring intermediate variables, using `exti_readl` directly in `g_assert_cmpuint` so that QEMU coding style is respected Changes from v5 to v6: - in `stm32l4x5_exti-test.c` : using a helper function `exti_set_irq()` to help readability - in `stm32l4x5_exti-test.c` : correct a mistake in test `test_edge_selector` (adding a necessary NVIC interrupt unpend so that the assert actually checks something) - in `stm32l4x5_soc.c` : reducing scope of `i` used in for loops - in `stm32l4x5_soc.c` : removing useless variable `dev` - swapping commit 2 (add tests) and commit 3 (connects exti to SoC) so that the tests pass in the commit they're added Changes from v4 to v5: - update the documentation file Changes from v3 to v4: - add a test to check that irq trigger selection works correctly (`test_edge_selector`) and correct `stm32l4x5_exti_set_irq` accordingly Changes from v2 to v3: - corrected the license to GPL Changes from v1 to v2: - correct the commit messages - remove a misleading comment Changes from v3 to v1: - separating the patch in 3 commits - justifying in the commit message why we implement a new model instead of changing the existing stm32f4xx_exti - changed irq_raise to irq_pulse in register SWIERx write (in `stm32l4x5_exti_write`) to be consistent with the irq_pulse in `stm32l4x5_exti_set_irq` (and also both these interrupts are edge-triggered) - changed the license to GPL Changes from v2 to v3: - adding more tests writing/reading in exti registers - adding tests checking that interrupt work by reading NVIC registers - correcting exti_write in SWIER (so it sets an irq only when a bit goes from '0' to '1') - correcting exti_set_irq (so it never writes in PR when the relevant bit in IMR is '0') Changes from v1 to v2: - use arrays to deduplicate code and logic - move internal constant `EXTI_NUM_GPIO_EVENT_IN_LINES` from the header to the .c file - Improve copyright headers - replace `static const` with `#define` - use the DEFINE_TYPES macro - fill the `impl` and `valid` field of the exti's `MemoryRegionOps` - fix invalid test caused by a last minute change Based-on: 20240108135849.351719-1-ines.var...@telecom-paris.fr ([PATCH v6 0/2] Add minimal support for the B-L475E-IOT01A board) Inès Varhol (3): hw/misc: Implement STM32L4x5 EXTI hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC tests/qtest: Add STM32L4x5 EXTI QTest testcase docs/system/arm/b-l475e-iot01a.rst | 5 +- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 52 ++- hw/misc/Kconfig | 3 + hw/misc/meson.build | 1 + hw/misc/stm32l4x5_exti.c | 290 ++++++++++++++++ hw/misc/trace-events | 5 + include/hw/arm/stm32l4x5_soc.h | 3 + include/hw/misc/stm32l4x5_exti.h | 51 +++ tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 524 +++++++++++++++++++++++++++++ 11 files changed, 936 insertions(+), 4 deletions(-) create mode 100644 hw/misc/stm32l4x5_exti.c create mode 100644 include/hw/misc/stm32l4x5_exti.h create mode 100644 tests/qtest/stm32l4x5_exti-test.c -- 2.43.0