On Mon, Jan 08, 2024 at 05:13:56PM +0000, Daniel P. Berrangé wrote: > The qemu-img, qemu-io, qemu-nbd, qemu-storage-daemon tools all have > support for systemtap tracing built-in, so should be given corresponding > .stp files to define their probes. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > meson.build | 61 +++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 40 insertions(+), 21 deletions(-)
I'm less familiar with writing meson rules, but I can follow how you refactored the stap.found() logic to be shared among two different groups of traceable binaries, with the obvious difference being the generation of command:[] in a way that uses the correct prefixes per tracable item. And since I hit the problem of not being able to see trace output via qemu-trace-stap on qemu-io, this makes sense. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
