Am 12.03.2012 13:09, schrieb Floris Bos / Maxnet: > On 03/12/2012 12:57 PM, Kevin Wolf wrote: >> Am 10.03.2012 20:56, schrieb Floris Bos: >>> Some Linux distributions use the >>> /dev/disk/by-id/scsi-SATA_name-of-disk-model_serial addressing scheme >>> when refering to partitions in /etc/fstab and elsewhere. >>> This causes problems when starting a disk image taken from an existing >>> physical server under qemu, >>> because when running under qemu name-of-disk-model is always "QEMU HARDDISK" >>> This patch introduces a model=s option which in combination with the >>> existing serial=s option can be used to >>> fake the disk the operating system was previously on, allowing the OS to >>> boot properly. >>> >>> Cc: kw...@redhat.com >>> Signed-off-by: Floris Bos<d...@noc-ps.com> >> Oh, and now that I look at the actual patch, do we really want to add >> the model=... option to -drive? I think just the qdev property may be >> enough. When you need to set the option, you would need to use -device, >> but it's not that hard. > > Well, to me it makes sense to put it at the same places "serial" is, as > both options have quite similar functions: faking drive attributes.
-drive serial=... is older than -device, this is why it was okay back then and why we still have to maintain it for compatibility. If serial=... was a new patch today, I would probably be asking the same question there. Kevin
