Srivatsa Vaddagiri <quic_svadd...@quicinc.com> writes: > * Philippe Mathieu-Daud? <phi...@linaro.org> [2024-01-09 14:31:03]: > >> Hi Srivatsa, >> >> On 9/1/24 10:00, Srivatsa Vaddagiri wrote: >> > Specify the location of device-tree and its size, as Gunyah requires the >> > device-tree to be parsed before VM can begin its execution. >> > >> > Signed-off-by: Srivatsa Vaddagiri <quic_svadd...@quicinc.com> >> > --- >> > MAINTAINERS | 1 + >> > accel/stubs/gunyah-stub.c | 5 +++++ >> > hw/arm/virt.c | 6 ++++++ >> > include/sysemu/gunyah.h | 2 ++ >> > target/arm/gunyah.c | 45 +++++++++++++++++++++++++++++++++++++++ >> > target/arm/meson.build | 3 +++ >> > 6 files changed, 62 insertions(+) >> > create mode 100644 target/arm/gunyah.c >> >> (Please enable scripts/git.orderfile) > > Sure will do so from the next version! > >> >> > diff --git a/include/sysemu/gunyah.h b/include/sysemu/gunyah.h >> > index 4f26938521..a73d17bfb9 100644 >> > --- a/include/sysemu/gunyah.h >> > +++ b/include/sysemu/gunyah.h >> > @@ -27,4 +27,6 @@ typedef struct GUNYAHState GUNYAHState; >> > DECLARE_INSTANCE_CHECKER(GUNYAHState, GUNYAH_STATE, >> > TYPE_GUNYAH_ACCEL) >> > +int gunyah_arm_set_dtb(__u64 dtb_start, __u64 dtb_size); >> I'm getting: >> >> In file included from hw/intc/arm_gicv3_common.c:35: >> include/sysemu/gunyah.h:30:24: error: unknown type name '__u64' >> int gunyah_arm_set_dtb(__u64 dtb_start, __u64 dtb_size); >> ^ >> include/sysemu/gunyah.h:30:41: error: unknown type name '__u64' >> int gunyah_arm_set_dtb(__u64 dtb_start, __u64 dtb_size); >> ^ >> 2 errors generated. > > Hmm I don't get that error when compiling on Linux. I think uint64_t will work > better for all platforms where Qemu can get compiled?
Yes, aside from imported headers we state: In the event that you require a specific width, use a standard type like int32_t, uint32_t, uint64_t, etc. The specific types are mandatory for VMState fields. Don't use Linux kernel internal types like u32, __u32 or __le32. in style.rst > > - vatsa -- Alex Bennée Virtualisation Tech Lead @ Linaro