Peter Xu <pet...@redhat.com> writes: > On Mon, Nov 27, 2023 at 05:25:46PM -0300, Fabiano Rosas wrote: >> Make sure the data is flushed to disk before closing file >> channels. This will ensure data is on disk at the end of a migration >> to file. > > Looks reasonable, but just two (possibly naive) questions: > > (1) Does this apply to all io channel users, or only migration?
All file channel users. > > (2) Why metadata doesn't matter (v.s. fsync(), when CONFIG_FDATASYNC=y)? Syncing the inode information is not critical, it's mostly timestamp information (man inode). And fdatasync makes sure to sync any metadata that would be relevant for the retrieval of the data. > > Thanks,
