On Mon, 12 Mar 2012, Marc-Andr? Lureau wrote: > On Mon, Mar 12, 2012 at 9:51 PM, malc <av1...@comtv.ru> wrote: > >> > >> > b. Other drivers are not affected > >> > >> I don't see yet how, but I will review other drivers ctl_{in,out} > >> implementations > > > > You don't see how they can be affected or you don't see how you can > > figure that out? > > I don't see how they can be affected, unless they assert on an unknown > pcm_ctrl value VOICE_VOLUME for example (the calling call ignores > return value, so it alsa for example, can return -1 and it will get it = in? > ignored). > > >> > c. mixeng is not the default > >> > >> So you mean the last patch shouldn't be applied? Can you explain the > >> rationale? Why would we want broken behaviour by default? > >> > > > > Because i hate change. > > I do to, except when they fix broken behaviour. More seriously, do you > have other concerns with the mixemu code? >
Sure - it adds overhead. -- mailto:av1...@comtv.ru