On Tue, 30 Jan 2024 at 11:24, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > Hi Manos, > > On 30/1/24 12:02, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:57, Peter Maydell <peter.mayd...@linaro.org> > > wrote: > >> > >> On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis > >> <manos.pitsidiana...@linaro.org> wrote: > >>> > >>> On Tue, 30 Jan 2024 at 12:42, Peter Maydell <peter.mayd...@linaro.org> > >>> wrote: > >>>> > >>>> On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > >>>> <manos.pitsidiana...@linaro.org> wrote: > >>>>> > >>>>> On Tue, 30 Jan 2024 at 12:34, Peter Maydell <peter.mayd...@linaro.org> > >>>>> wrote: > >>>>>> > >>>>>> On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > >>>>>> <manos.pitsidiana...@linaro.org> wrote: > >>>>>>> > >>>>>>> Check if a file argument is a cover letter patch produced by > >>>>>>> git-format-patch --cover-letter; It is initialized with subject > >>>>>>> suffix " > >>>>>>> *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > >>>>>>> exist, warn the user. > >>>>>> > >>>>>> FWIW, as far as I can see from my email archive, this particular > >>>>>> mistake has been made by contributors to qemu-devel perhaps > >>>>>> half a dozen times at most in the last decade... > >>>>>> > >>>>>> thanks > >>>>>> -- PMM > >>>>> > >>>>> Peter, searching for `b:"BLURB HERE"` in lore.kernel.org yields about > >>>>> 170 results including these patches. > >>>>> > >>>>> https://lore.kernel.org/qemu-devel/?q=b%3A%22BLURB+HERE%22 > > This comment is the default --blurb-template from git-publish: > https://github.com/stefanha/git-publish/blob/master/git-publish#L742 > As the tool is also used to post patches to other projects, I'd > recommend fixing it there at the source.
It's also in the general 'git format-patch' cover letter template, where the workflow is supposed to be "produce cover letter template, manually edit it, send it". Stray template markers generally are the result of (a) a new contributor not knowing about the 'edit' step or (b) remembering to add the subject and blurb but forgetting to delete the 'blurb' template line so it gets left in at the bottom of the cover letter. So I think it is a check that is within checkpatch.pl's remit. thanks -- PMM
