On Tue, Jan 30, 2024 at 03:16:34AM +0000, JeeHeng Sia wrote: ... > > I think either there should be a comment that this supports only v2 of > > SPCR spec or it should be able to create SPCR of any version. IMO, I > > think it is better to add support till v4 (latest). Since consumers like > > Linux probably doesn't support v4 yet, ARM/RISC-V can continue to create > > v2 itself for the time being but the generic build_spcr() should be able > > to create v4 also if the arch requires it. > A v4 table depends on the updated acpica. I am not aware if there is a > request from ARM to update to v4. Anyway, RISC-V BRS Spec did mentioned > on poll-based sbi console. I can check with acpica community if updating > table to v4 is the go otherwise I would suggest we cont stick to v2 because > there is no compatible ACPI guest to test the code. > >
Generally we want to produce the oldest version which meets the requirements in order to support the widest set of consumers. Thanks, drew