Re: [PATCH 2/4] isa: extract FDC37M81X to a separate file

[Bernhard Beschow]

Am 30. Januar 2024 07:48:50 UTC schrieb "Philippe Mathieu-Daudé" 
<phi...@linaro.org>:
>On 29/1/24 21:26, Paolo Bonzini wrote:
>> On Mon, Jan 29, 2024 at 8:49 PM Bernhard Beschow <shen...@gmail.com> wrote:
>>> Don't we prefer a macro for below code? While touching the code we could 
>>> use it. (Sorry I can't recall its name from the top of my head and I don't 
>>> have access to the code right now).
>> 
>> Ah yeah, OBJECT_DEFINE_TYPE. Not sure it's much of a win because
>> neither finalize or instance_init are required here.
>
>Bernhard likely meant type_init() -> DEFINE_TYPES().

Indeed. And it doesn't cover the TypeInfo structure which for some reason I 
thought it did...

Anyway, I pointed this out because the maintainer of the device model gave 
similar comments in the past. So, speaking of maintainers: The MAINTAINERS file 
might need an update, too.

Best regards,
Bernhard