On Thu, 25 Jan 2024 at 19:42, Nabih Estefan <nabiheste...@google.com> wrote: > > From: Hao Wu <wuhao...@google.com> > > This patches adds a qtest for NPCM7XX PCI Mailbox module. > It sends read and write requests to the module, and verifies that > the module contains the correct data after the requests. > > Change-Id: I2e1dbaecf8be9ec7eab55cb54f7fdeb0715b8275 > Signed-off-by: Hao Wu <wuhao...@google.com> > Signed-off-by: Nabih Estefan <nabiheste...@google.com> > Reviewed-by: Tyrone Ting <kft...@nuvoton.com>
> +/* > + * Create a local TCP socket with any port, then save off the port we got. > + */ > +static in_port_t open_socket(void) This should be "int" -- you've lost a change that I noted in my review on v12 and made in the patchset I sent to the list in the pullreq. (in_port_t doesn't exist on Windows.) thanks -- PMM
