On Tue, Jan 23, 2024 at 9:38 AM Daniel Henrique Barboza <dbarb...@ventanamicro.com> wrote: > > Put 'name' declaration inside the loop, with g_autofree, to avoid > manually doing g_free() in each iteration. > > Signed-off-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.fran...@wdc.com> Alistair > --- > hw/riscv/virt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index d0f402e0d5..f8278df83f 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -820,12 +820,12 @@ static void create_fdt_virtio(RISCVVirtState *s, const > MemMapEntry *memmap, > uint32_t irq_virtio_phandle) > { > int i; > - char *name; > MachineState *ms = MACHINE(s); > > for (i = 0; i < VIRTIO_COUNT; i++) { > - name = g_strdup_printf("/soc/virtio_mmio@%lx", > + g_autofree char *name = g_strdup_printf("/soc/virtio_mmio@%lx", > (long)(memmap[VIRT_VIRTIO].base + i * memmap[VIRT_VIRTIO].size)); > + > qemu_fdt_add_subnode(ms->fdt, name); > qemu_fdt_setprop_string(ms->fdt, name, "compatible", "virtio,mmio"); > qemu_fdt_setprop_cells(ms->fdt, name, "reg", > @@ -840,7 +840,6 @@ static void create_fdt_virtio(RISCVVirtState *s, const > MemMapEntry *memmap, > qemu_fdt_setprop_cells(ms->fdt, name, "interrupts", > VIRTIO_IRQ + i, 0x4); > } > - g_free(name); > } > } > > -- > 2.43.0 > >