On Tue, Feb 06, 2024 at 02:31:49PM +0800, pet...@redhat.com wrote: > From: Peter Xu <pet...@redhat.com> > > Recently we introduced cross-binary migration test. It's always wanted > that migration-test uses stable guest ABI for both QEMU binaries in this > case, so that both QEMU binaries will be compatible on the migration > stream with the cmdline specified. > > Switch to a static gic version "3" rather than using version "max", so that > GIC should be stable now across any future QEMU binaries for migration-test. > > Here the version can actually be anything as long as the ABI is stable. We > choose "3" because it's the majority of what we already use in QEMU while > still new enough: "git grep gic-version=3" shows 6 hit, while version 4 has > no direct user yet besides "max". > > Note that even with this change, aarch64 won't be able to work yet with > migration cross binary test, but then the only missing piece will be the > stable CPU model. > > Signed-off-by: Peter Xu <pet...@redhat.com> > --- > tests/qtest/migration-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
