On Tue, Feb 06, 2024 at 11:19:03PM +0000, Hao Xiang wrote:
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 819708321d..ff033a0344 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -874,6 +874,11 @@
> # @mode: Migration mode. See description in @MigMode. Default is 'normal'.
> # (Since 8.2)
> #
> +# @multifd-zero-page: Multifd zero page checking. If the parameter is true,
> +# zero page checking is done on the multifd sender thread. If the
> parameter
> +# is false, zero page checking is done on the migration main thread.
> Default
> +# is set to true. (Since 9.0)
I replied somewhere before on this, but I can try again..
Do you think it'll be better to introduce a generic parameter for zero page
detection?
- "none" if disabled,
- "legacy" for main thread,
- "multifd" for multifd (software-based).
A string could work, but maybe cleaner to introduce
@MigrationZeroPageDetector enum?
When you add more, you can keep extending that with the single field
("multifd-dsa", etc.).
--
Peter Xu
