On Wed, 7 Feb 2024, Paolo Bonzini wrote:
ISA_SUPERIO does not provide an ISA bus, so it should not select the symbol:
instead it requires one.  Among its users, VT82C686 is the only one that
is a PCI-ISA bridge and does not already select ISA_BUS.

Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>

Reviewed-by: BALATON Zoltan <bala...@eik.bme.hu>

---
hw/isa/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
index 7884179d08b..5df3c09cd51 100644
--- a/hw/isa/Kconfig
+++ b/hw/isa/Kconfig
@@ -15,7 +15,7 @@ config I82378

config ISA_SUPERIO
    bool
-    select ISA_BUS
+    depends on ISA_BUS
    select PCKBD
    select PARALLEL
    select SERIAL_ISA
@@ -47,6 +47,7 @@ config PIIX

config VT82C686
    bool
+    select ISA_BUS
    select ISA_SUPERIO
    select ACPI
    select ACPI_SMBUS


Reply via email to