Re: [PATCH 09/14] vfio: Add Error** argument to .vfio_save_config() handler

[Philippe Mathieu-Daudé]

On 7/2/24 14:33, Cédric Le Goater wrote:

Use vmstate_save_state_with_err() to improve error reporting in the
callers.

Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
  include/hw/vfio/vfio-common.h |  2 +-
  hw/vfio/migration.c           | 18 ++++++++++++------
  hw/vfio/pci.c                 |  5 +++--
  3 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index 
9b7ef7d02b5a0ad5266bcc4d06cd6874178978e4..710e0d6a880b97848af6ddc2e7968a01054fa122
 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -133,7 +133,7 @@ struct VFIODeviceOps {
      int (*vfio_hot_reset_multi)(VFIODevice *vdev);
      void (*vfio_eoi)(VFIODevice *vdev);
      Object *(*vfio_get_object)(VFIODevice *vdev);
-    void (*vfio_save_config)(VFIODevice *vdev, QEMUFile *f);
+    int (*vfio_save_config)(VFIODevice *vdev, QEMUFile *f, Error **errp);

Worth a one-line docstring?

Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

      int (*vfio_load_config)(VFIODevice *vdev, QEMUFile *f);
  };