Am 7. Februar 2024 19:03:30 UTC schrieb "Philippe Mathieu-Daudé"
<phi...@linaro.org>:
>On 7/2/24 12:14, Paolo Bonzini wrote:
>> Right now all subclasses of TYPE_ISA_SUPERIO have to specify an
>> instance_size,
>> because the ISASuperIODevice struct adds fields to ISADevice but the type
>> does
>> not include the increased instance size. Failure to do so results in an
>> access
>> past the bounds of struct ISADevice as soon as isa_superio_realize is called.
>> Fix this by specifying the instance_size already in the superclass.
>>
>> Cc: Bernhard Beschow <shen...@gmail.com>
>> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
>> ---
>> hw/isa/isa-superio.c | 2 +-
>> hw/isa/smc37c669-superio.c | 1 -
>> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>Oops, thanks!
>
>Fixes: 4c3119a6e3 ("hw/isa/superio: Factor out the parallel code from
>pc87312.c")
>Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Fixes a latent bug which thankfully isn't materialized at the moment.
Reviewed-by: Bernhard Beschow <shen...@gmail.com>
