On 2024/02/14 15:53, Michael S. Tsirkin wrote:
On Wed, Feb 14, 2024 at 02:13:46PM +0900, Akihiko Odaki wrote:
I couldn't find such a behavior specified.
Is it fixing a bug or just removing unnecessary code?
Is this guest visible at all?
My intention is just to remove unnecessary code, but it is
guest-visible. The original behavior causes a problem and it should be
considered as a bug fix if a guest expects VFs can be restored by
setting VF Enable after clearing it, but I don't know such an example.
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
hw/pci/pcie_sriov.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c
index 9d668b8d6c17..410bc090fc58 100644
--- a/hw/pci/pcie_sriov.c
+++ b/hw/pci/pcie_sriov.c
@@ -209,7 +209,6 @@ static void unregister_vfs(PCIDevice *dev)
pci_set_enabled(dev->exp.sriov_pf.vf[i], false);
}
dev->exp.sriov_pf.num_vfs = 0;
- pci_set_word(dev->config + dev->exp.sriov_cap + PCI_SRIOV_NUM_VF, 0);
}
void pcie_sriov_config_write(PCIDevice *dev, uint32_t address,
--
2.43.0
