Hi Fan, >-----Original Message----- >From: fan <nifan....@gmail.com> >Sent: 15 February 2024 18:09 >To: Shiju Jose <shiju.j...@huawei.com> >Cc: qemu-devel@nongnu.org; linux-...@vger.kernel.org; Jonathan Cameron ><jonathan.came...@huawei.com>; tanxiaofei <tanxiao...@huawei.com>; >Zengtao (B) <prime.z...@hisilicon.com>; Linuxarm <linux...@huawei.com> >Subject: Re: [PATCH v2 0/3] hw/cxl/cxl-mailbox-utils: Add feature commands, >device patrol scrub control and DDR5 ECS control features > >On Fri, Nov 24, 2023 at 09:53:34PM +0800, shiju.j...@huawei.com wrote: >> From: Shiju Jose <shiju.j...@huawei.com> >> >> Add support for the feature commands, device patrol scrub control and >> DDR5 ECS control features. >> >> CXL spec 3.0 section 8.2.9.6 describes optional device specific features. >> CXL spec 3.1 section 8.2.9.9.11.1 describes the device patrol scrub >> control feature. >> CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub >> (ECS) control feature. >> >> The patches are available here, >> https://gitlab.com/shiju.jose/qemu/-/tree/cxl-scrub-2023-11-14 >> and is based on Jonathan's branch >> https://gitlab.com/jic23/qemu/-/tree/cxl-2023-10-16 >> >> Changes >> v1 -> v2 >> 1. Changes for Davidlohr comments. Thanks. >> - Changed CXL SET feature data transfer flags as enum. >> - Modified pointer supported_feats to get_feats_out. >> - Removed an unnecessary branch. >> - Use MIN(). >> - Move setting of hdr.nsuppfeats further down. >> - Return CXL_MBOX_UNSUPPORTED if non-zero selection flag is passed. >> - Add more IMMEDIATE_*.* flags set_feature. >> - Corrected a spelling error. >> >> Shiju Jose (3): >> hw/cxl/cxl-mailbox-utils: Add support for feature commands (8.2.9.6) >> hw/cxl/cxl-mailbox-utils: Add device patrol scrub control feature >> hw/cxl/cxl-mailbox-utils: Add device DDR5 ECS control feature >> >> hw/cxl/cxl-mailbox-utils.c | 360 >> +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 360 insertions(+) >> >> -- >> 2.34.1 >> > >Recently, Jonathan has updated all the specification references to align >with cxl spec r3.1, so for the next version, we may want to also do >that.
I had posted recently v3 of this series updated for spec r3.1. Please find, https://lore.kernel.org/qemu-devel/20240215110146.1444-1-shiju.j...@huawei.com/T/#t > >Fan Thanks, Shiju
